From 63ecad8042c73e26c7b95ac15fadcca5d22d331b Mon Sep 17 00:00:00 2001 From: Ivan Smolin Date: Thu, 22 Jul 2021 09:29:22 +0300 Subject: [PATCH] remove hadcoded CODE_SIGN_STYLE key; remove PROVISIONING_PROFILE_SPECIFIER auto generation --- xcode/config_generator/render_xcconfigs.rb | 17 +++-------------- xcode/config_generator/target_xcconfig.mustache | 4 +--- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/xcode/config_generator/render_xcconfigs.rb b/xcode/config_generator/render_xcconfigs.rb index 69aee0b..c96c120 100755 --- a/xcode/config_generator/render_xcconfigs.rb +++ b/xcode/config_generator/render_xcconfigs.rb @@ -64,23 +64,12 @@ def fetch_development_team(development_team_key, distribution_type) return config_option(development_team_key, team_value) end -# Return empty array or generated provisioning profile hash -def generate_provisioning_profile(provisioning_key, bundle_id, distribution_type) - case distribution_type - when "appstore" - app_store_profile = "match AppStore " + bundle_id - config_option(provisioning_key, app_store_profile) - else - config_option(provisioning_key, bundle_id) - end -end - # Generate missing properties if needed def generate_missing_properties(target_name, properties, distribution_type) result = [] development_team_key = "DEVELOPMENT_TEAM" - provisioning_key = "PROVISIONING_PROFILE_SPECIFIER" bundle_id_key = "PRODUCT_BUNDLE_IDENTIFIER" + code_sign_style_key = "CODE_SIGN_STYLE" # Bundle_id_key should be among the properties (required by fastlane) unless properties.key?(bundle_id_key) @@ -91,8 +80,8 @@ def generate_missing_properties(target_name, properties, distribution_type) result.append(fetch_development_team(development_team_key, distribution_type)) end - unless properties.key?(provisioning_key) - result.append(generate_provisioning_profile(provisioning_key, properties[bundle_id_key], distribution_type)) + unless properties.key?(code_sign_style_key) + result.append(config_option(code_sign_style_key, "Manual")) end return result diff --git a/xcode/config_generator/target_xcconfig.mustache b/xcode/config_generator/target_xcconfig.mustache index 7e5477a..570fab1 100644 --- a/xcode/config_generator/target_xcconfig.mustache +++ b/xcode/config_generator/target_xcconfig.mustache @@ -2,6 +2,4 @@ {{#configuration.xcconfig_options}} {{key}} = {{value}} -{{/configuration.xcconfig_options}} - -CODE_SIGN_STYLE = Manual \ No newline at end of file +{{/configuration.xcconfig_options}} \ No newline at end of file