Deprecated `:SyncSymbols` removed, `upload_symbols_to_crashlytics` moved to a common building step, `compileBitcode` removed

xcode/commonFastfile

@@ -54,10 +54,6 @@ private_lane :uploadToFirebase do |options|
       release_notes_file: releaseNotesFile
     )
   end
-
-  upload_symbols_to_crashlytics(
-    gsp_path: get_google_services_plist_path(app_target_folder_name, configuration_type)
-  )
 end
 
 def upload_to_app_store_using_options(options)
@@ -138,19 +134,20 @@ private_lane :buildConfiguration do |options|
     sync_code_signing_using_options(options)
     addShield(options)
     buildArchive(options)
-
     uploadToFirebase(options)
   end
 
   if options[:uploadToAppStore]
-    options[:compileBitcode] = options[:compileBitcode].nil? ? true : options[:compileBitcode]
     options[:include_symbols] = options[:include_symbols].nil? ? true : options[:include_symbols]
 
     sync_code_signing_using_options(options)
-
     buildArchive(options)
     upload_to_app_store_using_options(options)
   end
+
+  upload_symbols_to_crashlytics(
+    gsp_path: get_google_services_plist_path(app_target_folder_name, configuration_type)
+  )
 end
 
 private_lane :buildArchive do |options|
@@ -159,7 +156,6 @@ private_lane :buildArchive do |options|
 
   icloudEnvironment = options[:iCloudContainerEnvironment] || ""
   exportOptions = icloudEnvironment.to_s.empty? ? {} : {iCloudContainerEnvironment: icloudEnvironment}
-  exportOptions[:compileBitcode] = options[:compileBitcode] || false
 
   lane_name = options[:lane_name]
   configuration = options[:configuration]
@@ -194,8 +190,7 @@ private_lane :buildArchive do |options|
     export_method: options[:export_method],
     export_options: exportOptions,
     skip_package_ipa: options[:skip_package_ipa],
-    include_symbols: options[:include_symbols] || false,
-    include_bitcode: options[:compileBitcode] || false,
+    include_symbols: options[:include_symbols] || false
   )
 end
 
@@ -228,36 +223,6 @@ lane :SyncCodeSigning do |options|
   sync_code_signing_using_options(options)
 end
 
-lane :SyncSymbols do |options|
-  configuration = get_configuration_for_type(options[:type])
-  options = configuration.to_options.merge(options)
-
-  appName = options[:appName] || $appName
-
-  xcodeproj_path = File.expand_path "../#{appName}.xcodeproj"
-
-  version_number = options[:version] || "latest"
-  build_number = options[:build_number]
-
-  if configuration.type.is_app_store
-    download_dsyms(
-      username: options[:username],
-      app_identifier: options[:app_identifier].first,
-      team_id: options[:itc_team_id],
-      version: version_number,
-      build_number: build_number
-    )
-  end
-
-  app_target_folder_name = appName
-
-  upload_symbols_to_crashlytics(
-    gsp_path: get_google_services_plist_path(app_target_folder_name, configuration.type)
-  )
-
-  clean_build_artifacts
-end
-
 private_lane :openKeychain do |options|
   if is_ci?
     # workaround to avoid duplication problem