TouchInstinct
/
BuildScripts
304
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases Wiki Activity

fixed code review

This commit is contained in:
Maxim Bachinsky 2020-09-08 19:04:43 +03:00
parent 64e9c6182e
commit adf2946881
4 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gradle/plugins/src/main/java/static_analysis/linters/AndroidLinter.kt
View File

@ -8,7 +8,7 @@ import static_analysis.errors.AndroidLintError
import static_analysis.errors.StaticAnalysisError import static_analysis.errors.StaticAnalysisError
import static_analysis.plugins.StaticAnalysisExtension import static_analysis.plugins.StaticAnalysisExtension
import static_analysis.utils.typedChildren import static_analysis.utils.typedChildren
import xmlParser import static_analysis.utils.xmlParser
class AndroidLinter : Linter { class AndroidLinter : Linter {
@ -52,15 +52,18 @@ class AndroidLinter : Linter {
} }
override fun getTaskNames(project: Project, buildType: String?): List<String> { override fun getTaskNames(project: Project, buildType: String?): List<String> {
if (buildType == null) throw IllegalStateException("build type must not be null in android linter") if (buildType == null) {
throw IllegalStateException("Build type must not be null in android linter")
}
return project return project
.subprojects .subprojects
.filter { it.plugins.hasPlugin(AppPlugin::class.java) } .filter { it.plugins.hasPlugin(AppPlugin::class.java) }
.mapNotNull { subproject: Project -> .mapNotNull { subproject: Project ->
subproject.tasks.find { task -> subproject
task.name.contains(buildType, ignoreCase = true) && task.name.contains("lint") .tasks
}?.path .find { task -> task.name.contains(buildType, ignoreCase = true) && task.name.contains("lint") }
?.path
} }
} }

2
gradle/plugins/src/main/java/static_analysis/linters/CpdLinter.kt
View File

@ -10,7 +10,7 @@ import static_analysis.errors.StaticAnalysisError
import static_analysis.plugins.StaticAnalysisExtension import static_analysis.plugins.StaticAnalysisExtension
import static_analysis.utils.getSources import static_analysis.utils.getSources
import static_analysis.utils.typedChildren import static_analysis.utils.typedChildren
import xmlParser import static_analysis.utils.xmlParser
class CpdLinter : Linter { class CpdLinter : Linter {

2
gradle/plugins/src/main/java/static_analysis/linters/DetektLinter.kt
View File

@ -7,7 +7,7 @@ import static_analysis.errors.StaticAnalysisError
import static_analysis.plugins.StaticAnalysisExtension import static_analysis.plugins.StaticAnalysisExtension
import static_analysis.utils.getSources import static_analysis.utils.getSources
import static_analysis.utils.typedChildren import static_analysis.utils.typedChildren
import xmlParser import static_analysis.utils.xmlParser
class DetektLinter : Linter { class DetektLinter : Linter {

2
gradle/plugins/src/main/java/static_analysis/utils/XmlUtils.kt
View File

@ -1,3 +1,5 @@
package static_analysis.utils
import groovy.util.XmlParser import groovy.util.XmlParser
import java.io.File import java.io.File