From e9b619df87ae396ba8ff731771280cfdff9fa569 Mon Sep 17 00:00:00 2001
From: Vladimir Shefer <quameu@gmail.com>
Date: Fri, 22 May 2020 21:17:00 +0300
Subject: [PATCH] Refactoring in apiGenerator scripts

---
 gradle/apiGenerator.gradle             | 28 ++++++++++++----------
 gradle/apiGeneratorKotlinServer.gradle | 32 +++++++++++++++-----------
 2 files changed, 34 insertions(+), 26 deletions(-)

diff --git a/gradle/apiGenerator.gradle b/gradle/apiGenerator.gradle
index 66bd565..12eac76 100644
--- a/gradle/apiGenerator.gradle
+++ b/gradle/apiGenerator.gradle
@@ -19,18 +19,22 @@ android.applicationVariants.all { variant ->
     final File generatedModelsDirectory = new File("${project.buildDir}/generated/source/models/${variant.dirName}")
 
     def generateJsonModelsTask = tasks.create("apiGenerator${variant.name}") doLast {
-        def jarArgs = new ArrayList<String>()
-        jarArgs.add(configurations.apigenerator.asPath)
-        jarArgs.add("generate-client-code")
-        jarArgs.add("--output-language")
-        jarArgs.add("JAVA")
-        jarArgs.add("--specification-path")
-        jarArgs.add(rootProject.extensions.findByName("pathToApiSchemes"))
-        jarArgs.add("--output-path")
-        jarArgs.add("${generatedModelsDirectory.path}")
-        jarArgs.add("--package-name")
-        jarArgs.add("${rootProject.extensions.findByName("applicationId") ?: applicationId}")
-        javaexec { main = "-jar"; args = jarArgs; workingDir = file("${rootDir}") }
+        javaexec {
+            main = "-jar"
+            workingDir = file("${rootDir}")
+            args = [
+                    configurations.apigenerator.asPath,
+                    "generate-client-code",
+                    "--output-language",
+                    "JAVA",
+                    "--specification-path",
+                    rootProject.extensions.findByName("pathToApiSchemes"),
+                    "--output-path",
+                    "${generatedModelsDirectory.path}",
+                    "--package-name",
+                    "${rootProject.extensions.findByName("applicationId") ?: applicationId}"
+            ]
+        }
     }
 
     generateJsonModelsTask.description = 'Generates Java classes for JSON models'
diff --git a/gradle/apiGeneratorKotlinServer.gradle b/gradle/apiGeneratorKotlinServer.gradle
index 8fc0d6c..66676b5 100644
--- a/gradle/apiGeneratorKotlinServer.gradle
+++ b/gradle/apiGeneratorKotlinServer.gradle
@@ -16,19 +16,23 @@ dependencies {
 }
 
 task generateApiModelsKotlinServer doLast {
-    def jarArgs = new ArrayList<String>()
-    jarArgs.add(configurations.apigeneratorKotlinServer.asPath)
-    jarArgs.add("generate-client-code")
-    jarArgs.add("--output-language")
-    jarArgs.add("KOTLIN_SERVER")
-    jarArgs.add("--specification-path")
-    jarArgs.add(rootProject.extensions.findByName("pathToApiSchemes"))
-    jarArgs.add("--output-path")
-    jarArgs.add("${rootDir}/src/main/kotlin")
-    jarArgs.add("--package-name")
-    jarArgs.add(rootProject.extensions.findByName("apiPackageName"))
-    jarArgs.add("--recreate_output_dirs")
-    jarArgs.add(false)
-    javaexec { main = "-jar"; args = jarArgs; workingDir = file("${rootDir}") }
+    javaexec {
+        main = "-jar"
+        workingDir = file("${rootDir}")
+        args = [
+                configurations.apigeneratorKotlinServer.asPath,
+                "generate-client-code",
+                "--output-language",
+                "KOTLIN_SERVER",
+                "--specification-path",
+                rootProject.extensions.findByName("pathToApiSchemes"),
+                "--output-path",
+                "${rootDir}/src/main/kotlin",
+                "--package-name",
+                rootProject.extensions.findByName("apiPackageName"),
+                "--recreate_output_dirs",
+                false
+        ]
+    }
 }