Commit Graph

17 Commits

Author SHA1 Message Date
Diego Sánchez 37dd3bd562 Minor performance improvements for TextBubble (#166)
* Minor performance improvements:
 - Avoids updating font and color in TextBubble if it's not needed: would make attributed text to update
 - Avoids updating views in selected setter if value didn't change (setter is called by the collection view as part of dequeuing)
 - Avoids creating dictionary of attributes all the time for date attributed string (for some reason this was appearing in profiling with some swift-to-objc conversions)

Uses enum as image key in text style for greater safety.

* Removes linter warnings
2016-06-27 23:03:32 +01:00
Diego Sánchez 29173b03b5 Fixes text sizing issue. (#161)
Setting UITextView.textColor after UITextView.text may result in a NSTextStorage string that doesn't match our size calculation routine.
2016-06-23 14:41:08 +01:00
Diego Sánchez d87fe40c90 Some optimizations for TextBubbleView (#144) 2016-06-01 13:43:37 +01:00
Diego Sánchez 3b62da46a3 Text bubble fixes (#127)
* Fixes diacritic marks being clipped.

This changes how text insetting is performed. By using non-zero textInsets, UITextView size is now bigger and diacritic marks can be seen.

* Fixes size of text not matching UITextView.sizeThatFits(_:) for some strings - which was leading to incorrect size of text bubbles -
2016-05-12 15:54:56 +01:00
Anton Schukin 136473d1b0 Fixed issue with text size calculation v2 2016-05-05 16:37:51 +01:00
Anton Schukin 47f6692eca Revert "Merge pull request #122 from AntonPalich/Fix_text_size_calculation"
This reverts commit 06655cdd77, reversing
changes made to acc9900c98.
2016-05-05 16:33:01 +01:00
Anton Schukin 5a9c096e02 Fixed text size calculation 2016-05-05 14:47:50 +01:00
Diego Sanchez eb84520fff Updates to Swift 2.2 2016-04-11 14:22:56 +01:00
Diego Sanchez f16bb098ae Fixes blink on iOS 8 when sending text messages 2016-03-23 11:30:59 +00:00
Diego Sanchez 2c5b065d5c Improvements for custom styling
- Allows reusing default styles by injecting parameters
 - Insets and fonts for input component
2016-03-21 20:49:30 +00:00
Zhao Wang 6e0d014571 Fix a class name typo
BaseMessageCollectionViewCellDefaultSyle  ->
BaseMessageCollectionViewCellDefaultStyle
2016-03-08 22:02:59 -08:00
Barış Çamur c7d4fcfbd5 Make Subclassing BaseMessageCollectionViewCell Possible Outside of ChattoAdditions Module
-This commit exposes messageViewModel, createBubbleView() and init
functions of BaseMessageCollectionViewCell class to other modules by
changing their access modifiers to ‘public’.
-This also requires to change the access level of createBubbleView()
function of  TextMessageCollectionViewCell and
PhotoMessageCollectionViewCell to be made ‘public’
2016-02-26 17:20:14 +02:00
Diego Sanchez da05cb2a09 Relax MessageModelProtocol and MessageViewModelProtocol requirements.
MessageModelProtocol should not require setter for status property.
MessageViewModelProtocol should not require messageModel property.

Both are convenience shortcuts for DemoChatApp and should be removed since they are not used by ChattoAdditions framework.
2016-02-18 12:37:50 +00:00
Diego Sanchez a040604f05 Makes TextMessageViewModelDefaultBuilder generic so it can build view models from different concrete models 2016-02-03 13:36:23 +00:00
Diego Sanchez d46bdb214c Relaxes generic constraints so presenters can be reused with different models 2016-02-03 13:06:03 +00:00
Diego Sanchez a0a071afa8 Fixes linter warnings and updates some rules. Also removes deprecated '++' and '--' 2016-01-27 22:04:32 +00:00
Diego Sanchez 2884160061 Chatto inception 2015-11-26 22:48:25 +00:00