TouchInstinct
/
LeadKit
310
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix code review note

This commit is contained in:
Ivan Smolin 2018-05-21 19:16:12 +03:00
parent 8c3c3cb7f5
commit 6417b43df8
3 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Sources/Classes/DataLoading/RxNetworkOperationModel.swift
View File

@ -42,7 +42,8 @@ open class RxNetworkOperationModel<LoadingStateType: NetworkOperationState>: Net
self.dataSource = dataSource
}
func execute() {
/// Performs request to given data source
public func execute() {
currentRequestDisposable?.dispose()
state = .initialLoadingState(after: state)

6
Sources/Enums/DataLoading/GeneralDataLoading/GeneralDataLoadingState.swift
View File

@ -27,7 +27,7 @@
/// - result: Result state from a specific data source with result.
/// - error: Error state with a specific error.
/// - empty: Empty state. When data was requested and empty result was received.
public enum GeneralDataLoadingState<DS: DataSource>: DataLoadingState {
public enum GeneralDataLoadingState<DS: DataSource> {
case initial
case loading
@ -35,6 +35,10 @@ public enum GeneralDataLoadingState<DS: DataSource>: DataLoadingState {
case error(error: Error)
case empty
}
extension GeneralDataLoadingState: DataLoadingState {
public typealias DataSourceType = DS
public static var initialState: GeneralDataLoadingState<DS> {

6
Sources/Enums/DataLoading/PaginationDataLoading/PaginationDataLoadingState.swift
View File

@ -29,7 +29,7 @@
/// - error: Error state with a specific error after a given state.
/// - empty: Empty state. When data was initially requested and empty result was received.
/// - exhausted: Exhausted state. When no more results can be received.
public indirect enum PaginationDataLoadingState<DS: DataSource>: DataLoadingState {
public indirect enum PaginationDataLoadingState<DS: DataSource> {
case initial
case initialLoading(after: PaginationDataLoadingState)
@ -39,6 +39,10 @@ public indirect enum PaginationDataLoadingState<DS: DataSource>: DataLoadingStat
case empty
case exhausted
}
extension PaginationDataLoadingState: DataLoadingState {
public typealias DataSourceType = DS
public static var initialState: PaginationDataLoadingState<DS> {