TouchInstinct
/
LeadKit
310
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: code review notes

This commit is contained in:
Ivan Smolin 2022-06-08 13:58:15 +03:00
parent 3d3d94412a
commit 9230450bb7
2 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
TIAuth/Sources/CodeConfirmPresenter/DefaultCodeConfirmPresenter.swift
View File

@ -74,15 +74,15 @@ open class DefaultCodeConfirmPresenter<ConfirmResponse: CodeConfirmResponse,
}
}
private let codeRefreshTimer = TITimer(mode: .activeAndBackground)
private let codeLifetimeTimer = TITimer(mode: .activeAndBackground)
public var output: Output
public var requests: Requests
public weak var stateStorage: CodeConfirmStateStorage?
public var config = Config()
public var currentCodeResponse: CodeResponse
private let codeRefreshTimer = TITimer(mode: .activeAndBackground)
private let codeLifetimeTimer = TITimer(mode: .activeAndBackground)
public init<Input: CodeResponse>(input: Input,
output: Output,
requests: Requests,
@ -101,11 +101,9 @@ open class DefaultCodeConfirmPresenter<ConfirmResponse: CodeConfirmResponse,
let confirmResponse = await requests.confirmRequest(code)
if self.isSuccessConfirm(response: confirmResponse) {
handle(successConfirmResponse: confirmResponse)
} else {
handle(failureConfirmResponse: confirmResponse)
}
isSuccessConfirm(response: confirmResponse)
? handle(successConfirmResponse: confirmResponse)
: handle(failureConfirmResponse: confirmResponse)
stateStorage?.isExecutingRequest = false
}
@ -242,7 +240,7 @@ open class DefaultCodeConfirmPresenter<ConfirmResponse: CodeConfirmResponse,
codeRefreshTimer.eventHandler = { [weak self] in
self?.updateRemaining(nonRefreshableInterval: nonRefreshableInterval,
elapsedInterval: $0)
elapsedInterval: $0)
}
codeRefreshTimer.start()
}

8
TIMoyaNetworking/Sources/NetworkService/EndpointErrorResult.swift
View File

@ -23,12 +23,12 @@
import Moya
import Foundation
public enum EndpointErrorResult<AE, NE>: Error {
case apiError(AE)
case networkError(NE)
public enum EndpointErrorResult<ApiError, NetworkError>: Error {
case apiError(ApiError)
case networkError(NetworkError)
}
public extension EndpointErrorResult where NE == MoyaError {
public extension EndpointErrorResult where NetworkError == MoyaError {
var isNetworkConnectionProblem: Bool {
guard case let .networkError(moyaError) = self,
case let .underlying(error, _) = moyaError,