From b10fcdc7e4ed1375a4f5c78ef8ce80bffa5d0b67 Mon Sep 17 00:00:00 2001 From: Ivan Smolin Date: Thu, 6 Oct 2016 14:43:47 +0300 Subject: [PATCH] code review notes --- LeadKit/LeadKit/Classes/Logging/Log.swift | 7 ++++--- LeadKit/LeadKit/Classes/Logging/LogFormatter.swift | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/LeadKit/LeadKit/Classes/Logging/Log.swift b/LeadKit/LeadKit/Classes/Logging/Log.swift index 752d8905..f1c4e4e4 100644 --- a/LeadKit/LeadKit/Classes/Logging/Log.swift +++ b/LeadKit/LeadKit/Classes/Logging/Log.swift @@ -15,14 +15,15 @@ open class Log { open let fileLogger = DDFileLogger() init() { - DDLog.add(fileLogger) DDLog.add(DDASLLogger.sharedInstance()) DDLog.add(DDTTYLogger.sharedInstance()) - DDASLLogger.sharedInstance().logFormatter = LogFormatter() - DDTTYLogger.sharedInstance().logFormatter = LogFormatter() + let logFormatter = LogFormatter() + + DDASLLogger.sharedInstance().logFormatter = logFormatter + DDTTYLogger.sharedInstance().logFormatter = logFormatter let assertionHandler = NSAssertionHandler() diff --git a/LeadKit/LeadKit/Classes/Logging/LogFormatter.swift b/LeadKit/LeadKit/Classes/Logging/LogFormatter.swift index 86a232fb..0aab1d1d 100644 --- a/LeadKit/LeadKit/Classes/Logging/LogFormatter.swift +++ b/LeadKit/LeadKit/Classes/Logging/LogFormatter.swift @@ -11,7 +11,7 @@ import CocoaLumberjack import CocoaLumberjack.DDDispatchQueueLogFormatter class LogFormatter: DDDispatchQueueLogFormatter { - let dateFormatter: DateFormatter + fileprivate let dateFormatter: DateFormatter override init() { dateFormatter = DateFormatter()