fix: code review notes
This commit is contained in:
parent
4e1270205e
commit
bd7d31cf67
|
|
@ -53,4 +53,22 @@ open class ContainerTableViewCell<View: UIView>: BaseInitializableCell, WrappedV
|
|||
open func createView() -> View {
|
||||
return View()
|
||||
}
|
||||
|
||||
// MARK: - Open methods
|
||||
|
||||
public func configureContainerTableViewCell(appearance: BaseWrappedViewHolderAppearance<some WrappedViewAppearance, some ViewLayout>) {
|
||||
contentInsets = appearance.subviewAppearance.layout.insets
|
||||
configureUIView(appearance: appearance)
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - AppearanceConfigurable
|
||||
|
||||
extension ContainerTableViewCell: AppearanceConfigurable where View: AppearanceConfigurable,
|
||||
View.Appearance: WrappedViewAppearance {
|
||||
|
||||
public func configure(appearance: DefaultWrappedViewHolderAppearance<View.Appearance, UIView.NoLayout>) {
|
||||
configureContainerTableViewCell(appearance: appearance)
|
||||
wrappedView.configure(appearance: appearance.subviewAppearance)
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -20,6 +20,7 @@
|
|||
// THE SOFTWARE.
|
||||
//
|
||||
|
||||
import TIUIKitCore
|
||||
import UIKit
|
||||
|
||||
public final class ContainerView<View: UIView>: BaseInitializableView, WrappedViewHolder {
|
||||
|
|
@ -48,3 +49,26 @@ public final class ContainerView<View: UIView>: BaseInitializableView, WrappedVi
|
|||
contentEdgeConstraints = configureWrappedViewLayout()
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - ConfigurableView
|
||||
|
||||
extension ContainerView: ConfigurableView where View: ConfigurableView {
|
||||
|
||||
public func configure(with viewModel: View.ViewModelType) {
|
||||
wrappedView.configure(with: viewModel)
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - AppearanceConfigurable
|
||||
|
||||
extension ContainerView: AppearanceConfigurable where View: AppearanceConfigurable,
|
||||
View.Appearance: WrappedViewAppearance {
|
||||
|
||||
public typealias Appearance = UIView.DefaultWrappedViewHolderAppearance<View.Appearance, UIView.DefaultWrappedLayout>
|
||||
|
||||
public func configure(appearance: Appearance) {
|
||||
wrappedView.configure(appearance: appearance.subviewAppearance)
|
||||
configureUIView(appearance: appearance)
|
||||
contentInsets = appearance.subviewAppearance.layout.insets
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,40 +0,0 @@
|
|||
//
|
||||
// Copyright (c) 2023 Touch Instinct
|
||||
//
|
||||
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
// of this software and associated documentation files (the Software), to deal
|
||||
// in the Software without restriction, including without limitation the rights
|
||||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
// copies of the Software, and to permit persons to whom the Software is
|
||||
// furnished to do so, subject to the following conditions:
|
||||
//
|
||||
// The above copyright notice and this permission notice shall be included in
|
||||
// all copies or substantial portions of the Software.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||
// THE SOFTWARE.
|
||||
//
|
||||
|
||||
import TIUIKitCore
|
||||
import UIKit
|
||||
|
||||
extension ContainerTableViewCell: AppearanceConfigurable where View: AppearanceConfigurable,
|
||||
View.Appearance: WrappedViewAppearance {
|
||||
|
||||
public func configure(appearance: DefaultWrappedViewHolderAppearance<View.Appearance, UIView.NoLayout>) {
|
||||
configureContainerTableViewCell(appearance: appearance)
|
||||
wrappedView.configure(appearance: appearance.subviewAppearance)
|
||||
}
|
||||
}
|
||||
|
||||
extension ContainerTableViewCell {
|
||||
public func configureContainerTableViewCell(appearance: BaseWrappedViewHolderAppearance<some WrappedViewAppearance, some ViewLayout>) {
|
||||
contentInsets = appearance.subviewAppearance.layout.insets
|
||||
configureUIView(appearance: appearance)
|
||||
}
|
||||
}
|
||||
|
|
@ -1,47 +0,0 @@
|
|||
//
|
||||
// Copyright (c) 2023 Touch Instinct
|
||||
//
|
||||
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
// of this software and associated documentation files (the Software), to deal
|
||||
// in the Software without restriction, including without limitation the rights
|
||||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
// copies of the Software, and to permit persons to whom the Software is
|
||||
// furnished to do so, subject to the following conditions:
|
||||
//
|
||||
// The above copyright notice and this permission notice shall be included in
|
||||
// all copies or substantial portions of the Software.
|
||||
//
|
||||
// THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||
// THE SOFTWARE.
|
||||
//
|
||||
|
||||
import TIUIKitCore
|
||||
import UIKit
|
||||
|
||||
// MARK: - ConfigurableView
|
||||
|
||||
extension ContainerView: ConfigurableView where View: ConfigurableView {
|
||||
|
||||
public func configure(with viewModel: View.ViewModelType) {
|
||||
wrappedView.configure(with: viewModel)
|
||||
}
|
||||
}
|
||||
|
||||
// MARK: - AppearanceConfigurable
|
||||
|
||||
extension ContainerView: AppearanceConfigurable where View: AppearanceConfigurable,
|
||||
View.Appearance: WrappedViewAppearance {
|
||||
|
||||
public typealias Appearance = UIView.DefaultWrappedViewHolderAppearance<View.Appearance, UIView.DefaultWrappedLayout>
|
||||
|
||||
public func configure(appearance: Appearance) {
|
||||
wrappedView.configure(appearance: appearance.subviewAppearance)
|
||||
configureUIView(appearance: appearance)
|
||||
contentInsets = appearance.subviewAppearance.layout.insets
|
||||
}
|
||||
}
|
||||
Loading…
Reference in New Issue