TouchInstinct
/
LeadKit
302
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

code review notes

This commit is contained in:
Ivan Smolin 2018-03-23 11:29:24 +03:00
parent bfaf668191
commit cb694dcbcf
4 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Sources/Classes/DataLoading/GeneralDataLoading/GeneralDataLoadingViewModel.swift
View File

@ -33,7 +33,7 @@ open class GeneralDataLoadingViewModel<ResultType>: BaseViewModel {
private let loadingStateVariable = Variable<LoadingState>(.initial)
private let disposeBag = DisposeBag()
public let disposeBag = DisposeBag()
/// Initializer with single result sequence and empty result checker closure.
///

3
Sources/Classes/Views/DefaultPlaceholders/TextPlaceholderView.swift
View File

@ -22,8 +22,7 @@
import UIKit
/// For internal use only!
final class TextPlaceholderView: UIView {
internal final class TextPlaceholderView: UIView {
enum PlaceholderText: String {

3
Sources/Classes/Views/DefaultPlaceholders/TextWithButtonPlaceholder.swift
View File

@ -22,8 +22,7 @@
import UIKit
/// For internal use only!
final class TextWithButtonPlaceholder: UIView {
internal final class TextWithButtonPlaceholder: UIView {
typealias TapHandler = () -> Void

7
Sources/Extensions/DataLoading/GeneralDataLoading/GeneralDataLoadingController+DefaultImplementation.swift
View File

@ -20,10 +20,17 @@
// THE SOFTWARE.
//
import RxSwift
import RxCocoa
public extension GeneralDataLoadingController where Self: UIViewController {
// MARK: - DisposeBagHolder default implementation
var disposeBag: DisposeBag {
return viewModel.disposeBag
}
// MARK: - StatefulViewController default implementation
func hasContent() -> Bool {