From 5d2b0977bde028146978d434115cad98ca08585f Mon Sep 17 00:00:00 2001 From: Tosin Afolabi Date: Mon, 11 Nov 2019 10:26:03 -0800 Subject: [PATCH] Swift 5.0 Support --- PanModal.podspec | 4 ++-- PanModalDemo.xcodeproj/project.pbxproj | 14 ++++++++------ README.md | 10 +++++++--- 3 files changed, 17 insertions(+), 11 deletions(-) diff --git a/PanModal.podspec b/PanModal.podspec index 03701ab..26694a8 100644 --- a/PanModal.podspec +++ b/PanModal.podspec @@ -8,7 +8,7 @@ Pod::Spec.new do |s| s.name = 'PanModal' - s.version = '1.2.4' + s.version = '1.2.5' s.summary = 'PanModal is an elegant and highly customizable presentation API for constructing bottom sheet modals on iOS.' # This description is used to generate tags and improve search results. @@ -24,6 +24,6 @@ Pod::Spec.new do |s| s.source = { :git => 'https://github.com/slackhq/PanModal.git', :tag => s.version.to_s } s.social_media_url = 'https://twitter.com/slackhq' s.ios.deployment_target = '10.0' - s.swift_version = '4.2' + s.swift_version = '5.0' s.source_files = 'PanModal/**/*.{swift,h,m}' end diff --git a/PanModalDemo.xcodeproj/project.pbxproj b/PanModalDemo.xcodeproj/project.pbxproj index 3c214d9..0fe4e14 100644 --- a/PanModalDemo.xcodeproj/project.pbxproj +++ b/PanModalDemo.xcodeproj/project.pbxproj @@ -629,7 +629,7 @@ PRODUCT_BUNDLE_IDENTIFIER = com.slack.PanModal; PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)"; SKIP_INSTALL = YES; - SWIFT_VERSION = 4.2; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; VERSIONING_SYSTEM = "apple-generic"; VERSION_INFO_PREFIX = ""; @@ -658,7 +658,7 @@ PRODUCT_BUNDLE_IDENTIFIER = com.slack.PanModal; PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)"; SKIP_INSTALL = YES; - SWIFT_VERSION = 4.2; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; VERSIONING_SYSTEM = "apple-generic"; VERSION_INFO_PREFIX = ""; @@ -679,7 +679,7 @@ ); PRODUCT_BUNDLE_IDENTIFIER = slack.PanModalTests; PRODUCT_NAME = "$(TARGET_NAME)"; - SWIFT_VERSION = 4.2; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; TEST_HOST = "$(BUILT_PRODUCTS_DIR)/PanModalDemo.app/PanModalDemo"; }; @@ -699,7 +699,7 @@ ); PRODUCT_BUNDLE_IDENTIFIER = slack.PanModalTests; PRODUCT_NAME = "$(TARGET_NAME)"; - SWIFT_VERSION = 4.2; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; TEST_HOST = "$(BUILT_PRODUCTS_DIR)/PanModalDemo.app/PanModalDemo"; }; @@ -763,6 +763,7 @@ SDKROOT = iphoneos; SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG; SWIFT_OPTIMIZATION_LEVEL = "-Onone"; + SWIFT_VERSION = 5.0; }; name = Debug; }; @@ -817,6 +818,7 @@ SDKROOT = iphoneos; SWIFT_COMPILATION_MODE = wholemodule; SWIFT_OPTIMIZATION_LEVEL = "-O"; + SWIFT_VERSION = 5.0; VALIDATE_PRODUCT = YES; }; name = Release; @@ -837,7 +839,7 @@ ); PRODUCT_BUNDLE_IDENTIFIER = com.PanModal; PRODUCT_NAME = "$(TARGET_NAME)"; - SWIFT_VERSION = 4.2; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; }; name = Debug; @@ -858,7 +860,7 @@ ); PRODUCT_BUNDLE_IDENTIFIER = com.PanModal; PRODUCT_NAME = "$(TARGET_NAME)"; - SWIFT_VERSION = 4.2; + SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; }; name = Release; diff --git a/README.md b/README.md index a314f96..98b0356 100644 --- a/README.md +++ b/README.md @@ -1,15 +1,13 @@ ### PanModal is an elegant and highly customizable presentation API for constructing bottom sheet modals on iOS. -Read our blog on how Slack is getting more :thumbsup: with PanModal -

Screenshot Preview

Platform: iOS 10.0+ - Language: Swift 4 + Language: Swift 5 CocoaPods compatible Carthage compatible License: MIT @@ -26,6 +24,12 @@ Read our License

+

+Read our blog on how Slack is getting more :thumbsup: with PanModal + +Swift 4.2 support can be found on the `Swift4.2` branch. +

+ ## Features * Supports any type of `UIViewController`