diff --git a/src/main/java/ru/touchin/roboswag/components/navigation/ViewController.java b/src/main/java/ru/touchin/roboswag/components/navigation/ViewController.java index 9237cbd..c36a111 100644 --- a/src/main/java/ru/touchin/roboswag/components/navigation/ViewController.java +++ b/src/main/java/ru/touchin/roboswag/components/navigation/ViewController.java @@ -20,6 +20,7 @@ package ru.touchin.roboswag.components.navigation; import android.os.Bundle; +import android.support.annotation.CallSuper; import android.support.annotation.NonNull; import android.support.annotation.Nullable; import android.support.annotation.StringRes; @@ -74,7 +75,7 @@ public class ViewController, * @return Returns activity. */ @NonNull - public TActivity getActivity() { + public final TActivity getActivity() { return activity; } @@ -84,7 +85,7 @@ public class ViewController, * @return Returns fragment. */ @NonNull - public TFragment getFragment() { + public final TFragment getFragment() { return fragment; } @@ -95,7 +96,7 @@ public class ViewController, * @return Returns view. */ @NonNull - public ViewGroup getContainer() { + public final ViewGroup getContainer() { return container; } @@ -104,7 +105,7 @@ public class ViewController, * * @return True if it is destroyed. */ - public boolean isDestroyed() { + public final boolean isDestroyed() { return destroyed; } @@ -141,19 +142,19 @@ public class ViewController, @NonNull @Override - public Subscription bind(@NonNull final Observable observable, @NonNull final Action1 onNextAction) { + public final Subscription bind(@NonNull final Observable observable, @NonNull final Action1 onNextAction) { return baseUiBindable.bind(observable, onNextAction); } @NonNull @Override - public Observable untilStop(@NonNull final Observable observable) { + public final Observable untilStop(@NonNull final Observable observable) { return baseUiBindable.untilStop(observable); } @NonNull @Override - public Observable untilDestroy(@NonNull final Observable observable) { + public final Observable untilDestroy(@NonNull final Observable observable) { return baseUiBindable.untilDestroy(observable); } @@ -161,6 +162,7 @@ public class ViewController, * Calls right after construction of {@link ViewController}. * Happens at {@link ViewControllerFragment#onActivityCreated(View, ViewControllerActivity, Bundle)}. */ + @CallSuper public void onCreate() { baseUiBindable.onCreate(); } @@ -169,6 +171,7 @@ public class ViewController, * Calls when {@link ViewController} have started. * Happens at {@link ViewControllerFragment#onStart(View, ViewControllerActivity)}. */ + @CallSuper public void onStart() { baseUiBindable.onStart(); } @@ -178,6 +181,7 @@ public class ViewController, * Happens at {@link ViewControllerFragment#onSaveInstanceState(Bundle)}. * Try not to use such method for saving state but use {@link ViewControllerFragment#getState()} from {@link #getFragment()}. */ + @CallSuper public void onSaveInstanceState(@NonNull final Bundle savedInstanceState) { // do nothing } @@ -186,6 +190,7 @@ public class ViewController, * Calls when {@link ViewController} have stopped. * Happens at {@link ViewControllerFragment#onStop(View, ViewControllerActivity)}. */ + @CallSuper public void onStop() { baseUiBindable.onStop(); } @@ -194,6 +199,7 @@ public class ViewController, * Calls when {@link ViewController} have destroyed. * Happens usually at {@link ViewControllerFragment#onDestroyView(View)}. In some cases at {@link ViewControllerFragment#onDestroy()}. */ + @CallSuper public void onDestroy() { baseUiBindable.onDestroy(); destroyed = true; diff --git a/src/main/java/ru/touchin/roboswag/components/navigation/fragments/ViewFragment.java b/src/main/java/ru/touchin/roboswag/components/navigation/fragments/ViewFragment.java index ba5424f..757d465 100644 --- a/src/main/java/ru/touchin/roboswag/components/navigation/fragments/ViewFragment.java +++ b/src/main/java/ru/touchin/roboswag/components/navigation/fragments/ViewFragment.java @@ -20,6 +20,7 @@ package ru.touchin.roboswag.components.navigation.fragments; import android.os.Bundle; +import android.support.annotation.CallSuper; import android.support.annotation.NonNull; import android.support.annotation.Nullable; import android.support.v4.app.Fragment; @@ -57,7 +58,7 @@ public abstract class ViewFragment extends */ @SuppressWarnings("unchecked") @Nullable - protected TActivity getBaseActivity() { + protected final TActivity getBaseActivity() { if (getActivity() == null) { return null; } @@ -79,6 +80,7 @@ public abstract class ViewFragment extends } @Override + @CallSuper public void onFragmentStarted(@NonNull final Fragment fragment) { //do nothing } @@ -101,6 +103,7 @@ public abstract class ViewFragment extends * @param activity Activity which fragment attached to. * @param savedInstanceState If the fragment is being re-created from a previous saved state, this is the state. */ + @CallSuper public void onActivityCreated(@NonNull final View view, @NonNull final TActivity activity, @Nullable final Bundle savedInstanceState) { //do nothing } @@ -126,6 +129,7 @@ public abstract class ViewFragment extends * @param view Instantiated view. * @param activity Activity which fragment attached to. */ + @CallSuper protected void onStart(@NonNull final View view, @NonNull final TActivity activity) { if (getParentFragment() instanceof OnFragmentStartedListener) { ((OnFragmentStartedListener) getParentFragment()).onFragmentStarted(this); @@ -147,6 +151,7 @@ public abstract class ViewFragment extends * @param view Instantiated view. * @param activity Activity which fragment attached to. */ + @CallSuper protected void onResume(@NonNull final View view, @NonNull final TActivity activity) { //do nothing } @@ -164,6 +169,7 @@ public abstract class ViewFragment extends * @param view Instantiated view. * @param activity Activity which fragment attached to. */ + @CallSuper protected void onPause(@NonNull final View view, @NonNull final TActivity activity) { //do nothing } @@ -181,6 +187,7 @@ public abstract class ViewFragment extends * @param view Instantiated view. * @param activity Activity which fragment attached to. */ + @CallSuper protected void onStop(@NonNull final View view, @NonNull final TActivity activity) { //do nothing } @@ -201,6 +208,7 @@ public abstract class ViewFragment extends * * @param view Instantiated view. */ + @CallSuper protected void onDestroyView(@NonNull final View view) { //do nothing }