Merge pull request #50 from TouchInstinct/feature/input_type_attr

Feature/input type attr
This commit is contained in:
Gavriil 2017-03-06 20:30:52 +03:00 committed by GitHub
commit 362a9520d1
2 changed files with 29 additions and 0 deletions

View File

@ -25,6 +25,7 @@ import android.support.annotation.NonNull;
import android.support.annotation.Nullable; import android.support.annotation.Nullable;
import android.support.v7.widget.AppCompatEditText; import android.support.v7.widget.AppCompatEditText;
import android.text.Editable; import android.text.Editable;
import android.text.InputType;
import android.text.TextUtils; import android.text.TextUtils;
import android.text.TextWatcher; import android.text.TextWatcher;
import android.text.method.SingleLineTransformationMethod; import android.text.method.SingleLineTransformationMethod;
@ -160,6 +161,12 @@ public class TypefacedEditText extends AppCompatEditText {
"textSize required parameter. If it's dynamic then use '0sp'"); "textSize required parameter. If it's dynamic then use '0sp'");
AttributesUtils.checkAttribute(typedArray, errors, AttributesUtils.getField(androidRes, "TextView_inputType"), true, AttributesUtils.checkAttribute(typedArray, errors, AttributesUtils.getField(androidRes, "TextView_inputType"), true,
"inputType required parameter"); "inputType required parameter");
final int inputType = typedArray.getInt(AttributesUtils.getField(androidRes, "TextView_inputType"), -1);
if (AttributesUtils.isNumberInputType(inputType)) {
errors.add("use inputType phone instead of number");
}
AttributesUtils.checkAttribute(typedArray, errors, AttributesUtils.getField(androidRes, "TextView_imeOptions"), true, AttributesUtils.checkAttribute(typedArray, errors, AttributesUtils.getField(androidRes, "TextView_imeOptions"), true,
"imeOptions required parameter"); "imeOptions required parameter");
} }
@ -299,6 +306,17 @@ public class TypefacedEditText extends AppCompatEditText {
Lc.assertion(new IllegalStateException(AttributesUtils.viewError(this, "Do not specify ellipsize for EditText"))); Lc.assertion(new IllegalStateException(AttributesUtils.viewError(this, "Do not specify ellipsize for EditText")));
} }
@Override
public void setInputType(final int type) {
if (AttributesUtils.isNumberInputType(type)) {
Lc.assertion(new IllegalStateException(AttributesUtils.viewError(this,
"Do not specify number InputType for EditText, use phone instead")));
super.setInputType(InputType.TYPE_CLASS_PHONE);
return;
}
super.setInputType(type);
}
/** /**
* Sets typeface from 'assets/fonts' folder by name. * Sets typeface from 'assets/fonts' folder by name.
* *

View File

@ -23,6 +23,7 @@ import android.content.Context;
import android.content.res.TypedArray; import android.content.res.TypedArray;
import android.support.annotation.NonNull; import android.support.annotation.NonNull;
import android.support.annotation.StyleableRes; import android.support.annotation.StyleableRes;
import android.text.InputType;
import android.text.TextUtils; import android.text.TextUtils;
import android.util.AttributeSet; import android.util.AttributeSet;
import android.view.View; import android.view.View;
@ -149,6 +150,16 @@ public final class AttributesUtils {
return "Errors for view id=" + UiUtils.OfViews.getViewIdString(view) + ":\n" + errorText; return "Errors for view id=" + UiUtils.OfViews.getViewIdString(view) + ":\n" + errorText;
} }
/**
* Returns true if input type equals number input type.
*
* @param inputType Input type to check;
* @return true if input type equals number input type.
*/
public static boolean isNumberInputType(final int inputType) {
return inputType == InputType.TYPE_CLASS_NUMBER || inputType == InputType.TYPE_DATETIME_VARIATION_NORMAL;
}
private AttributesUtils() { private AttributesUtils() {
} }