TouchInstinct
/
RoboSwag-components
304
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #58 from TouchInstinct/phone_span_gfix 

warning of PhoneSpan fixed
This commit is contained in:
Gavriil 2017-04-08 22:47:13 +03:00 committed by GitHub
parent 93bb01e179 6840b3df74
commit 710bb184b9
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/java/ru/touchin/roboswag/components/utils/spans/PhoneSpan.java
View File

@ -1,5 +1,6 @@
package ru.touchin.roboswag.components.utils.spans;
import android.content.ActivityNotFoundException;
import android.content.Intent;
import android.net.Uri;
import android.support.annotation.NonNull;
@ -19,7 +20,6 @@ public class PhoneSpan extends URLSpan {
super(phoneNumber);
}
@SuppressWarnings("PMD.AvoidCatchingThrowable")
@Override
public void onClick(@NonNull final View widget) {
super.onClick(widget);
@ -27,9 +27,8 @@ public class PhoneSpan extends URLSpan {
final Intent intent = new Intent(Intent.ACTION_DIAL);
intent.setData(Uri.parse(getURL()));
widget.getContext().startActivity(intent);
// it should catch throwable to not crash in production if there are problems with startActivity()
} catch (final Throwable throwable) {
Lc.assertion(throwable);
} catch (final ActivityNotFoundException exception) {
Lc.assertion(exception);
}
}