From d96de591439cd18747dc3d2dc52db829a328bfdb Mon Sep 17 00:00:00 2001 From: Gavriil Sitnikov Date: Fri, 3 Jun 2016 18:18:42 +0300 Subject: [PATCH] useless change notifications removed --- .../core/observables/collections/ObservableList.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/java/ru/touchin/roboswag/core/observables/collections/ObservableList.java b/src/main/java/ru/touchin/roboswag/core/observables/collections/ObservableList.java index b0bfcd0..4e802d1 100644 --- a/src/main/java/ru/touchin/roboswag/core/observables/collections/ObservableList.java +++ b/src/main/java/ru/touchin/roboswag/core/observables/collections/ObservableList.java @@ -61,7 +61,9 @@ public class ObservableList extends ObservableCollection { public void addAll(final int position, @NonNull final Collection itemsToAdd) { items.addAll(position, itemsToAdd); - notifyAboutChange(new Change(Change.Type.INSERTED, position, itemsToAdd.size())); + if (!itemsToAdd.isEmpty()) { + notifyAboutChange(new Change(Change.Type.INSERTED, position, itemsToAdd.size())); + } } public void remove(final int position) { @@ -72,7 +74,9 @@ public class ObservableList extends ObservableCollection { public void clear() { final int oldSize = items.size(); items.clear(); - notifyAboutChange(new Change(Change.Type.REMOVED, 0, oldSize)); + if (oldSize > 0) { + notifyAboutChange(new Change(Change.Type.REMOVED, 0, oldSize)); + } } @NonNull