From 919445de07bee2db31f6877bcfcf863fb8c01040 Mon Sep 17 00:00:00 2001 From: Konstantin Kuzhim Date: Mon, 8 Nov 2021 22:30:32 +0700 Subject: [PATCH 1/2] add logging if non-null field is null --- .../touchin/templates/logansquare/LoganSquareJsonModel.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/api-logansquare/src/main/java/ru/touchin/templates/logansquare/LoganSquareJsonModel.java b/api-logansquare/src/main/java/ru/touchin/templates/logansquare/LoganSquareJsonModel.java index 3dbd536..b989c31 100644 --- a/api-logansquare/src/main/java/ru/touchin/templates/logansquare/LoganSquareJsonModel.java +++ b/api-logansquare/src/main/java/ru/touchin/templates/logansquare/LoganSquareJsonModel.java @@ -22,6 +22,7 @@ package ru.touchin.templates.logansquare; import androidx.annotation.Nullable; import ru.touchin.roboswag.core.log.Lc; +import ru.touchin.roboswag.core.log.LcGroup; import ru.touchin.templates.ApiModel; /** @@ -38,7 +39,9 @@ public abstract class LoganSquareJsonModel extends ApiModel { */ protected static void validateNotNull(@Nullable final Object object) throws ValidationException { if (object == null) { - throw new ValidationException("Not nullable object is null or missed at " + Lc.getCodePoint(null, 1)); + ValidationException exception = new ValidationException("Not nullable object is null or missed at " + Lc.getCodePoint(null, 1)); + LcGroup.API_VALIDATION.e(exception, "Invalid item"); + throw exception; } } From 0f890cbd1ea0775bc01f58a9590bc973c9b7a2d5 Mon Sep 17 00:00:00 2001 From: Konstantin Kuzhim Date: Mon, 8 Nov 2021 22:31:45 +0700 Subject: [PATCH 2/2] replace multi-log stacktrace printing with one-statement logging --- .../roboswag/core/log/ConsoleLogProcessor.java | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/logging/src/main/java/ru/touchin/roboswag/core/log/ConsoleLogProcessor.java b/logging/src/main/java/ru/touchin/roboswag/core/log/ConsoleLogProcessor.java index 8e00787..4f60198 100644 --- a/logging/src/main/java/ru/touchin/roboswag/core/log/ConsoleLogProcessor.java +++ b/logging/src/main/java/ru/touchin/roboswag/core/log/ConsoleLogProcessor.java @@ -29,8 +29,6 @@ import android.util.Log; */ public class ConsoleLogProcessor extends LogProcessor { - private static final int MAX_LOG_LENGTH = 4000; - public ConsoleLogProcessor(@NonNull final LcLevel lclevel) { super(lclevel); } @@ -46,18 +44,8 @@ public class ConsoleLogProcessor extends LogProcessor { public void processLogMessage(@NonNull final LcGroup group, @NonNull final LcLevel level, @NonNull final String tag, @NonNull final String message, @Nullable final Throwable throwable) { final String messageToLog = normalize(message + (throwable != null ? '\n' + Log.getStackTraceString(throwable) : "")); - final int length = messageToLog.length(); - for (int i = 0; i < length; i++) { - int newline = messageToLog.indexOf('\n', i); - newline = newline != -1 ? newline : length; - do { - final int end = Math.min(newline, i + MAX_LOG_LENGTH); - Log.println(level.getPriority(), tag, messageToLog.substring(i, end)); - i = end; - } - while (i < newline); - } + Log.println(level.getPriority(), tag, messageToLog); } }