TouchInstinct
/
RoboSwag
303
0
Fork 0
Code Issues Pull Requests 2 Packages Projects Releases Wiki Activity

Merge pull request #251 from TouchInstinct/remove_pretty_printer 

Remove pretty-print dependency from mvi module
This commit is contained in:
Grigorii 2022-04-18 12:14:10 +03:00 committed by GitHub
parent b7c6d88b0f 82e1cff525
commit f1189303b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mvi-arch/build.gradle
View File

@ -28,8 +28,6 @@ dependencies {
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core")
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android")
implementation("com.tylerthrailkill.helpers:pretty-print:2.0.2")
def fragmentVersion = "1.2.1"
def lifecycleVersion = "2.2.0"
def coroutinesVersion = "1.3.7"

6
mvi-arch/src/main/java/ru/touchin/roboswag/mvi_arch/core/MviViewModel.kt
View File

@ -9,8 +9,10 @@ import androidx.lifecycle.Transformations
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import kotlinx.coroutines.launch
import ru.touchin.mvi_arch.BuildConfig
import ru.touchin.roboswag.mvi_arch.marker.ViewAction
import ru.touchin.roboswag.mvi_arch.marker.ViewState
import ru.touchin.roboswag.mvi_arch.mediator.LoggingMediator
import ru.touchin.roboswag.mvi_arch.mediator.MediatorStore
/**
@ -40,9 +42,7 @@ abstract class MviViewModel<NavArgs : Parcelable, Action : ViewAction, State : V
private val mediatorStore = MediatorStore(
listOfNotNull(
// Min api 24
// https://github.com/TouchInstinct/RoboSwag/issues/180
// LoggingMediator(this::class.simpleName!!).takeIf { BuildConfig.DEBUG }
LoggingMediator(this::class.simpleName).takeIf { BuildConfig.DEBUG }
)
)

9
mvi-arch/src/main/java/ru/touchin/roboswag/mvi_arch/mediator/LoggingMediator.kt
View File

@ -1,13 +1,12 @@
package ru.touchin.roboswag.mvi_arch.mediator
import com.tylerthrailkill.helpers.prettyprint.pp
import ru.touchin.roboswag.core.log.Lc
import ru.touchin.roboswag.mvi_arch.marker.SideEffect
import ru.touchin.roboswag.mvi_arch.marker.StateChange
import ru.touchin.roboswag.mvi_arch.marker.ViewAction
import ru.touchin.roboswag.mvi_arch.marker.ViewState
class LoggingMediator(private val objectName: String) : Mediator {
class LoggingMediator(private val objectName: String?) : Mediator {
override fun onEffect(effect: SideEffect) {
logObject(
prefix = "New Effect:\n",
@ -40,10 +39,6 @@ class LoggingMediator(private val objectName: String) : Mediator {
prefix: String,
obj: T
) {
val builder = StringBuilder()
pp(obj = obj, writeTo = builder)
val prettyOutput = builder.toString()
Lc.d("$objectName: $prefix$prettyOutput\n")
Lc.d("$objectName: $prefix$obj\n")
}
}