From 72e5488631579c3ae0401e160cac84659f9fc6ed Mon Sep 17 00:00:00 2001 From: LZL Date: Wed, 3 Aug 2016 17:27:15 +0800 Subject: [PATCH 1/2] Typo --- Documentation/GettingStarted.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/GettingStarted.md b/Documentation/GettingStarted.md index 79f8a040..fad28786 100644 --- a/Documentation/GettingStarted.md +++ b/Documentation/GettingStarted.md @@ -133,7 +133,7 @@ This will print: 5 ``` -Note the you usually do not want to manually call `dispose`; this is only educational example. Calling dispose manually is usually a bad code smell. There are better ways to dispose subscriptions. We can use `DisposeBag`, the `takeUntil` operator, or some other mechanism. +Note that you usually do not want to manually call `dispose`; this is only educational example. Calling dispose manually is usually a bad code smell. There are better ways to dispose subscriptions. We can use `DisposeBag`, the `takeUntil` operator, or some other mechanism. So can this code print something after the `dispose` call executed? The answer is: it depends. From 208a84db0fb7c02f72d81e0ffcf5f511a5de8e82 Mon Sep 17 00:00:00 2001 From: Junior B Date: Sun, 7 Aug 2016 01:33:37 +0200 Subject: [PATCH 2/2] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2e55424d..b65cb038 100644 --- a/README.md +++ b/README.md @@ -44,7 +44,7 @@ KVO observing, async operations and streams are all unified under [abstraction o ###### ... interact -* All of this is great, but it would be nice to talk with other people using RxSwift and exchange experiences.
[![Slack channel](http://slack.rxswift.org/badge.svg)](http://slack.rxswift.org) [Join Slack Channel](http://slack.rxswift.org/) +* All of this is great, but it would be nice to talk with other people using RxSwift and exchange experiences.
[![Slack channel](http://rxswift-slack.herokuapp.com/badge.svg)](http://slack.rxswift.org) [Join Slack Channel](http://rxswift-slack.herokuapp.com) * Report a problem using the library. [Open an Issue With Bug Template](ISSUE_TEMPLATE.md) * Request a new feature. [Open an Issue With Feature Request Template](Documentation/NewFeatureRequestTemplate.md)