TouchInstinct
/
RxSwift
303
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

get rid of memory leaking in UIKit unit tests

This commit is contained in:
persidskiy 2015-12-04 01:41:59 +03:00
parent ebf146ca41
commit 7fa016f7b8
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
RxSwift/Subjects/Variable.swift
View File

@ -62,6 +62,7 @@ public class Variable<Element> : ObservableType {
- parameter observer: Observer to subscribe to variable values.
- returns: Disposable object that can be used to unsubscribe the observer from the variable.
*/
@warn_unused_result(message="http://git.io/rxs.ud")
public func subscribe<O: ObserverType where O.E == E>(observer: O) -> Disposable {
return _subject.subscribe(observer)
}

13
RxTests/RxCocoaTests/Control+RxTests+UIKit.swift
View File

@ -15,7 +15,8 @@ extension ControlTests {
func testSubscribeEnabledToTrue() {
let subject = UIControl()
let enabledSequence = Variable<Bool>(false)
enabledSequence.subscribe(subject.rx_enabled)
let disposable = enabledSequence.subscribe(subject.rx_enabled)
defer { disposable.dispose() }
enabledSequence.value = true
XCTAssert(subject.enabled == true, "Expected enabled set to true")
@ -24,7 +25,8 @@ extension ControlTests {
func testSubscribeEnabledToFalse() {
let subject = UIControl()
let enabledSequence = Variable<Bool>(true)
enabledSequence.subscribe(subject.rx_enabled)
let disposable = enabledSequence.subscribe(subject.rx_enabled)
defer { disposable.dispose() }
enabledSequence.value = false
XCTAssert(subject.enabled == false, "Expected enabled set to false")
@ -163,8 +165,8 @@ extension ControlTests {
func testLabel_NextElementsSetsValue() {
let subject = UILabel()
let attributedTextSequence = Variable<NSAttributedString?>(nil)
attributedTextSequence.subscribe(subject.rx_attributedText)
let disposable = attributedTextSequence.subscribe(subject.rx_attributedText)
defer { disposable.dispose() }
attributedTextSequence.value = NSAttributedString(string: "Hello!")
XCTAssert(subject.attributedText == attributedTextSequence.value, "Expected attributedText to have been set")
@ -323,7 +325,8 @@ extension ControlTests {
let subject = UIActivityIndicatorView()
let boolSequence = Variable<Bool>(false)
boolSequence.subscribe(subject.rx_animating)
let disposable = boolSequence.subscribe(subject.rx_animating)
defer { disposable.dispose() }
boolSequence.value = true
XCTAssertTrue(subject.isAnimating(), "Expected animation to be started")