From e530858bd0f478dcfead1b22f60e169773876d86 Mon Sep 17 00:00:00 2001 From: Mo Ramezanpoor Date: Fri, 29 Jul 2016 13:52:24 +0100 Subject: [PATCH 1/5] Renames `disposed` to `isDisposed` in any place that it makes semantically. --- Documentation/GettingStarted.md | 2 +- RxBlocking/BlockingObservable+Operators.swift | 8 +- RxSwift/Cancelable.swift | 2 +- RxSwift/Disposables/AnonymousDisposable.swift | 10 +-- RxSwift/Disposables/BinaryDisposable.swift | 8 +- RxSwift/Disposables/BooleanDisposable.swift | 18 ++-- RxSwift/Disposables/CompositeDisposable.swift | 2 +- RxSwift/Disposables/DisposeBag.swift | 6 +- RxSwift/Disposables/RefCountDisposable.swift | 6 +- RxSwift/Disposables/ScheduledDisposable.swift | 8 +- RxSwift/Disposables/SerialDisposable.swift | 14 ++-- .../SingleAssignmentDisposable.swift | 12 +-- .../Observables/Implementations/Buffer.swift | 2 +- .../Observables/Implementations/Debug.swift | 2 +- .../Observables/Implementations/Sink.swift | 2 +- .../Observables/Implementations/Timeout.swift | 2 +- .../Observables/Implementations/Window.swift | 2 +- RxSwift/Observers/TailRecursiveSink.swift | 6 +- .../Schedulers/ConcurrentMainScheduler.swift | 2 +- .../Schedulers/CurrentThreadScheduler.swift | 2 +- RxSwift/Schedulers/ImmediateScheduler.swift | 2 +- .../Internal/DispatchQueueConfiguration.swift | 6 +- .../Schedulers/Internal/ScheduledItem.swift | 6 +- RxSwift/Schedulers/MainScheduler.swift | 2 +- .../Schedulers/OperationQueueScheduler.swift | 2 +- RxSwift/Schedulers/RecursiveScheduler.swift | 6 +- RxSwift/Schedulers/VirtualTimeScheduler.swift | 6 +- RxSwift/Subjects/BehaviorSubject.swift | 16 ++-- RxSwift/Subjects/PublishSubject.swift | 14 ++-- RxSwift/Subjects/ReplaySubject.swift | 10 +-- Tests/RxCocoaTests/KVOObservableTests.swift | 84 +++++++++---------- .../TestImplementations/Mocks/MySubject.swift | 6 +- Tests/RxSwiftTests/Tests/DisposableTest.swift | 20 ++--- .../Tests/Observable+MultipleTest.swift | 6 +- 34 files changed, 151 insertions(+), 151 deletions(-) diff --git a/Documentation/GettingStarted.md b/Documentation/GettingStarted.md index 9bc5d8b4..69453083 100644 --- a/Documentation/GettingStarted.md +++ b/Documentation/GettingStarted.md @@ -387,7 +387,7 @@ func myInterval(interval: NSTimeInterval) -> Observable { dispatch_source_cancel(timer) } dispatch_source_set_event_handler(timer, { - if cancel.disposed { + if cancel.isDisposed { return } observer.on(.Next(next)) diff --git a/RxBlocking/BlockingObservable+Operators.swift b/RxBlocking/BlockingObservable+Operators.swift index 783feeb9..3df54e5e 100644 --- a/RxBlocking/BlockingObservable+Operators.swift +++ b/RxBlocking/BlockingObservable+Operators.swift @@ -30,7 +30,7 @@ extension BlockingObservable { lock.dispatch { d.disposable = self.source.subscribe { e in - if d.disposed { + if d.isDisposed { return } switch e { @@ -78,7 +78,7 @@ extension BlockingObservable { lock.dispatch { d.disposable = self.source.subscribe { e in - if d.disposed { + if d.isDisposed { return } @@ -130,7 +130,7 @@ extension BlockingObservable { lock.dispatch { d.disposable = self.source.subscribe { e in - if d.disposed { + if d.isDisposed { return } switch e { @@ -191,7 +191,7 @@ extension BlockingObservable { lock.dispatch { d.disposable = self.source.subscribe { e in - if d.disposed { + if d.isDisposed { return } switch e { diff --git a/RxSwift/Cancelable.swift b/RxSwift/Cancelable.swift index 54cc82e0..7d82d8ad 100644 --- a/RxSwift/Cancelable.swift +++ b/RxSwift/Cancelable.swift @@ -15,5 +15,5 @@ public protocol Cancelable : Disposable { /** - returns: Was resource disposed. */ - var disposed: Bool { get } + var isDisposed: Bool { get } } diff --git a/RxSwift/Disposables/AnonymousDisposable.swift b/RxSwift/Disposables/AnonymousDisposable.swift index 17a40910..0ee7d18e 100644 --- a/RxSwift/Disposables/AnonymousDisposable.swift +++ b/RxSwift/Disposables/AnonymousDisposable.swift @@ -16,14 +16,14 @@ When dispose method is called, disposal action will be dereferenced. public final class AnonymousDisposable : DisposeBase, Cancelable { public typealias DisposeAction = () -> Void - private var _disposed: AtomicInt = 0 + private var _isDisposed: AtomicInt = 0 private var _disposeAction: DisposeAction? /** - returns: Was resource disposed. */ - public var disposed: Bool { - return _disposed == 1 + public var isDisposed: Bool { + return _isDisposed == 1 } /** @@ -42,8 +42,8 @@ public final class AnonymousDisposable : DisposeBase, Cancelable { After invoking disposal action, disposal action will be dereferenced. */ public func dispose() { - if AtomicCompareAndSwap(0, 1, &_disposed) { - assert(_disposed == 1) + if AtomicCompareAndSwap(0, 1, &_isDisposed) { + assert(_isDisposed == 1) if let action = _disposeAction { _disposeAction = nil diff --git a/RxSwift/Disposables/BinaryDisposable.swift b/RxSwift/Disposables/BinaryDisposable.swift index b6176592..5b1883b6 100644 --- a/RxSwift/Disposables/BinaryDisposable.swift +++ b/RxSwift/Disposables/BinaryDisposable.swift @@ -13,7 +13,7 @@ Represents two disposable resources that are disposed together. */ public final class BinaryDisposable : DisposeBase, Cancelable { - private var _disposed: AtomicInt = 0 + private var _isDisposed: AtomicInt = 0 // state private var _disposable1: Disposable? @@ -22,8 +22,8 @@ public final class BinaryDisposable : DisposeBase, Cancelable { /** - returns: Was resource disposed. */ - public var disposed: Bool { - return _disposed > 0 + public var isDisposed: Bool { + return _isDisposed > 0 } /** @@ -44,7 +44,7 @@ public final class BinaryDisposable : DisposeBase, Cancelable { After invoking disposal action, disposal action will be dereferenced. */ public func dispose() { - if AtomicCompareAndSwap(0, 1, &_disposed) { + if AtomicCompareAndSwap(0, 1, &_isDisposed) { _disposable1?.dispose() _disposable2?.dispose() _disposable1 = nil diff --git a/RxSwift/Disposables/BooleanDisposable.swift b/RxSwift/Disposables/BooleanDisposable.swift index 05b8a43d..a976aa43 100644 --- a/RxSwift/Disposables/BooleanDisposable.swift +++ b/RxSwift/Disposables/BooleanDisposable.swift @@ -13,8 +13,8 @@ Represents a disposable resource that can be checked for disposal status. */ public class BooleanDisposable : Disposable, Cancelable { - internal static let BooleanDisposableTrue = BooleanDisposable(disposed: true) - private var _disposed = false + internal static let BooleanDisposableTrue = BooleanDisposable(isDisposed: true) + private var _isDisposed = false /** Initializes a new instance of the `BooleanDisposable` class @@ -25,21 +25,21 @@ public class BooleanDisposable : Disposable, Cancelable { /** Initializes a new instance of the `BooleanDisposable` class with given value */ - public init(disposed: Bool) { - self._disposed = disposed + public init(isDisposed: Bool) { + self._isDisposed = isDisposed } /** - returns: Was resource disposed. */ - public var disposed: Bool { - return _disposed + public var isDisposed: Bool { + return _isDisposed } /** - Sets the status to disposed, which can be observer through the `disposed` property. + Sets the status to disposed, which can be observer through the `isDisposed` property. */ public func dispose() { - _disposed = true + _isDisposed = true } -} \ No newline at end of file +} diff --git a/RxSwift/Disposables/CompositeDisposable.swift b/RxSwift/Disposables/CompositeDisposable.swift index a60c2730..43782262 100644 --- a/RxSwift/Disposables/CompositeDisposable.swift +++ b/RxSwift/Disposables/CompositeDisposable.swift @@ -19,7 +19,7 @@ public class CompositeDisposable : DisposeBase, Disposable, Cancelable { // state private var _disposables: Bag? = Bag() - public var disposed: Bool { + public var isDisposed: Bool { _lock.lock(); defer { _lock.unlock() } return _disposables == nil } diff --git a/RxSwift/Disposables/DisposeBag.swift b/RxSwift/Disposables/DisposeBag.swift index c466515d..2c7b6646 100644 --- a/RxSwift/Disposables/DisposeBag.swift +++ b/RxSwift/Disposables/DisposeBag.swift @@ -37,7 +37,7 @@ public class DisposeBag: DisposeBase { // state private var _disposables = [Disposable]() - private var _disposed = false + private var _isDisposed = false /** Constructs new empty dispose bag. @@ -67,7 +67,7 @@ public class DisposeBag: DisposeBase { private func _insert(_ disposable: Disposable) -> Disposable? { _lock.lock(); defer { _lock.unlock() } - if _disposed { + if _isDisposed { return disposable } @@ -93,7 +93,7 @@ public class DisposeBag: DisposeBase { let disposables = _disposables _disposables.removeAll(keepingCapacity: false) - _disposed = true + _isDisposed = true return disposables } diff --git a/RxSwift/Disposables/RefCountDisposable.swift b/RxSwift/Disposables/RefCountDisposable.swift index b7e46f7d..ff299bcc 100644 --- a/RxSwift/Disposables/RefCountDisposable.swift +++ b/RxSwift/Disposables/RefCountDisposable.swift @@ -20,7 +20,7 @@ public class RefCountDisposable : DisposeBase, Cancelable { /** - returns: Was resource disposed. */ - public var disposed: Bool { + public var isDisposed: Bool { _lock.lock(); defer { _lock.unlock() } return _disposable == nil } @@ -110,7 +110,7 @@ public class RefCountDisposable : DisposeBase, Cancelable { internal final class RefCountInnerDisposable: DisposeBase, Disposable { private let _parent: RefCountDisposable - private var _disposed: AtomicInt = 0 + private var _isDisposed: AtomicInt = 0 init(_ parent: RefCountDisposable) { @@ -120,7 +120,7 @@ internal final class RefCountInnerDisposable: DisposeBase, Disposable internal func dispose() { - if AtomicCompareAndSwap(0, 1, &_disposed) { + if AtomicCompareAndSwap(0, 1, &_isDisposed) { _parent.release() } } diff --git a/RxSwift/Disposables/ScheduledDisposable.swift b/RxSwift/Disposables/ScheduledDisposable.swift index 7e13f18f..5c7b08fc 100644 --- a/RxSwift/Disposables/ScheduledDisposable.swift +++ b/RxSwift/Disposables/ScheduledDisposable.swift @@ -19,7 +19,7 @@ Represents a disposable resource whose disposal invocation will be scheduled on public class ScheduledDisposable : Cancelable { public let scheduler: ImmediateSchedulerType - private var _disposed: AtomicInt = 0 + private var _isDisposed: AtomicInt = 0 // state private var _disposable: Disposable? @@ -27,8 +27,8 @@ public class ScheduledDisposable : Cancelable { /** - returns: Was resource disposed. */ - public var disposed: Bool { - return _disposed == 1 + public var isDisposed: Bool { + return _isDisposed == 1 } /** @@ -50,7 +50,7 @@ public class ScheduledDisposable : Cancelable { } func disposeInner() { - if AtomicCompareAndSwap(0, 1, &_disposed) { + if AtomicCompareAndSwap(0, 1, &_isDisposed) { _disposable!.dispose() _disposable = nil } diff --git a/RxSwift/Disposables/SerialDisposable.swift b/RxSwift/Disposables/SerialDisposable.swift index cb5c4e31..ff1f40b6 100644 --- a/RxSwift/Disposables/SerialDisposable.swift +++ b/RxSwift/Disposables/SerialDisposable.swift @@ -16,13 +16,13 @@ public class SerialDisposable : DisposeBase, Cancelable { // state private var _current = nil as Disposable? - private var _disposed = false + private var _isDisposed = false /** - returns: Was resource disposed. */ - public var disposed: Bool { - return _disposed + public var isDisposed: Bool { + return _isDisposed } /** @@ -47,7 +47,7 @@ public class SerialDisposable : DisposeBase, Cancelable { } set (newDisposable) { let disposable: Disposable? = _lock.calculateLocked { - if _disposed { + if _isDisposed { return newDisposable } else { @@ -72,14 +72,14 @@ public class SerialDisposable : DisposeBase, Cancelable { private func _dispose() -> Disposable? { _lock.lock(); defer { _lock.unlock() } - if _disposed { + if _isDisposed { return nil } else { - _disposed = true + _isDisposed = true let current = _current _current = nil return current } } -} \ No newline at end of file +} diff --git a/RxSwift/Disposables/SingleAssignmentDisposable.swift b/RxSwift/Disposables/SingleAssignmentDisposable.swift index a18ad82b..392b8f27 100644 --- a/RxSwift/Disposables/SingleAssignmentDisposable.swift +++ b/RxSwift/Disposables/SingleAssignmentDisposable.swift @@ -17,15 +17,15 @@ public class SingleAssignmentDisposable : DisposeBase, Disposable, Cancelable { private var _lock = SpinLock() // state - private var _disposed = false + private var _isDisposed = false private var _disposableSet = false private var _disposable = nil as Disposable? /** - returns: A value that indicates whether the object is disposed. */ - public var disposed: Bool { - return _disposed + public var isDisposed: Bool { + return _isDisposed } /** @@ -58,7 +58,7 @@ public class SingleAssignmentDisposable : DisposeBase, Disposable, Cancelable { _disposableSet = true - if _disposed { + if _isDisposed { return newValue } @@ -71,7 +71,7 @@ public class SingleAssignmentDisposable : DisposeBase, Disposable, Cancelable { Disposes the underlying disposable. */ public func dispose() { - if _disposed { + if _isDisposed { return } _dispose()?.dispose() @@ -80,7 +80,7 @@ public class SingleAssignmentDisposable : DisposeBase, Disposable, Cancelable { private func _dispose() -> Disposable? { _lock.lock(); defer { _lock.unlock() } - _disposed = true + _isDisposed = true let disposable = _disposable _disposable = nil diff --git a/RxSwift/Observables/Implementations/Buffer.swift b/RxSwift/Observables/Implementations/Buffer.swift index 823a4bcb..c2a4c822 100644 --- a/RxSwift/Observables/Implementations/Buffer.swift +++ b/RxSwift/Observables/Implementations/Buffer.swift @@ -92,7 +92,7 @@ class BufferTimeCountSink } func createTimer(_ windowID: Int) { - if _timerD.disposed { + if _timerD.isDisposed { return } diff --git a/RxSwift/Observables/Implementations/Debug.swift b/RxSwift/Observables/Implementations/Debug.swift index 43dd83cd..aa4e825b 100644 --- a/RxSwift/Observables/Implementations/Debug.swift +++ b/RxSwift/Observables/Implementations/Debug.swift @@ -46,7 +46,7 @@ class DebugSink : } override func dispose() { - logEvent(_parent._identifier, dateFormat: _timestampFormatter, content: "disposed") + logEvent(_parent._identifier, dateFormat: _timestampFormatter, content: "isDisposed") super.dispose() } } diff --git a/RxSwift/Observables/Implementations/Sink.swift b/RxSwift/Observables/Implementations/Sink.swift index 90fb5d00..018fd5ea 100644 --- a/RxSwift/Observables/Implementations/Sink.swift +++ b/RxSwift/Observables/Implementations/Sink.swift @@ -19,7 +19,7 @@ class Sink : SingleAssignmentDisposable { } final func forwardOn(_ event: Event) { - if disposed { + if isDisposed { return } _observer.on(event) diff --git a/RxSwift/Observables/Implementations/Timeout.swift b/RxSwift/Observables/Implementations/Timeout.swift index b6f9d21c..301cd576 100644 --- a/RxSwift/Observables/Implementations/Timeout.swift +++ b/RxSwift/Observables/Implementations/Timeout.swift @@ -72,7 +72,7 @@ class TimeoutSink: Sink(_ state: StateType, action: (StateType) -> Disposable) -> Disposable { let disposable = SingleAssignmentDisposable() _asyncLock.invoke(AnonymousInvocable { - if disposable.disposed { + if disposable.isDisposed { return } disposable.disposable = action(state) diff --git a/RxSwift/Schedulers/Internal/DispatchQueueConfiguration.swift b/RxSwift/Schedulers/Internal/DispatchQueueConfiguration.swift index 9b5c772a..87ffae3a 100644 --- a/RxSwift/Schedulers/Internal/DispatchQueueConfiguration.swift +++ b/RxSwift/Schedulers/Internal/DispatchQueueConfiguration.swift @@ -25,7 +25,7 @@ extension DispatchQueueConfiguration { let cancel = SingleAssignmentDisposable() queue.async { - if cancel.disposed { + if cancel.isDisposed { return } @@ -57,7 +57,7 @@ extension DispatchQueueConfiguration { } timer.setEventHandler(handler: { - if compositeDisposable.disposed { + if compositeDisposable.isDisposed { return } _ = compositeDisposable.insert(action(state)) @@ -91,7 +91,7 @@ extension DispatchQueueConfiguration { } timer.setEventHandler(handler: { - if cancelTimer.disposed { + if cancelTimer.isDisposed { return } timerState = action(timerState) diff --git a/RxSwift/Schedulers/Internal/ScheduledItem.swift b/RxSwift/Schedulers/Internal/ScheduledItem.swift index 693ac41e..1a6db082 100644 --- a/RxSwift/Schedulers/Internal/ScheduledItem.swift +++ b/RxSwift/Schedulers/Internal/ScheduledItem.swift @@ -18,8 +18,8 @@ struct ScheduledItem private let _disposable = SingleAssignmentDisposable() - var disposed: Bool { - return _disposable.disposed + var isDisposed: Bool { + return _disposable.isDisposed } init(action: Action, state: T) { @@ -34,4 +34,4 @@ struct ScheduledItem func dispose() { _disposable.dispose() } -} \ No newline at end of file +} diff --git a/RxSwift/Schedulers/MainScheduler.swift b/RxSwift/Schedulers/MainScheduler.swift index 44c9f09b..adc62211 100644 --- a/RxSwift/Schedulers/MainScheduler.swift +++ b/RxSwift/Schedulers/MainScheduler.swift @@ -61,7 +61,7 @@ public final class MainScheduler : SerialDispatchQueueScheduler { let cancel = SingleAssignmentDisposable() _mainQueue.async { - if !cancel.disposed { + if !cancel.isDisposed { _ = action(state) } diff --git a/RxSwift/Schedulers/OperationQueueScheduler.swift b/RxSwift/Schedulers/OperationQueueScheduler.swift index 24292aff..b20f3504 100644 --- a/RxSwift/Schedulers/OperationQueueScheduler.swift +++ b/RxSwift/Schedulers/OperationQueueScheduler.swift @@ -39,7 +39,7 @@ public class OperationQueueScheduler: ImmediateSchedulerType { weak var compositeDisposableWeak = compositeDisposable let operation = BlockOperation { - if compositeDisposableWeak?.disposed ?? false { + if compositeDisposableWeak?.isDisposed ?? false { return } diff --git a/RxSwift/Schedulers/RecursiveScheduler.swift b/RxSwift/Schedulers/RecursiveScheduler.swift index c820b7d1..36191f6d 100644 --- a/RxSwift/Schedulers/RecursiveScheduler.swift +++ b/RxSwift/Schedulers/RecursiveScheduler.swift @@ -41,7 +41,7 @@ class AnyRecursiveScheduler { var removeKey: CompositeDisposable.DisposeKey? = nil let d = _scheduler.scheduleRelative(state, dueTime: dueTime) { (state) -> Disposable in // best effort - if self._group.disposed { + if self._group.isDisposed { return NopDisposable.instance } @@ -84,7 +84,7 @@ class AnyRecursiveScheduler { var removeKey: CompositeDisposable.DisposeKey? = nil let d = _scheduler.schedule(state) { (state) -> Disposable in // best effort - if self._group.disposed { + if self._group.isDisposed { return NopDisposable.instance } @@ -154,7 +154,7 @@ class RecursiveImmediateScheduler { var removeKey: CompositeDisposable.DisposeKey? = nil let d = _scheduler.schedule(state) { (state) -> Disposable in // best effort - if self._group.disposed { + if self._group.isDisposed { return NopDisposable.instance } diff --git a/RxSwift/Schedulers/VirtualTimeScheduler.swift b/RxSwift/Schedulers/VirtualTimeScheduler.swift index 96974f90..baefc975 100644 --- a/RxSwift/Schedulers/VirtualTimeScheduler.swift +++ b/RxSwift/Schedulers/VirtualTimeScheduler.swift @@ -169,7 +169,7 @@ public class VirtualTimeScheduler func findNext() -> VirtualSchedulerItem? { while let front = _schedulerQueue.peek() { - if front.disposed { + if front.isDisposed { _schedulerQueue.remove(front) continue } @@ -263,8 +263,8 @@ class VirtualSchedulerItem