diff --git a/RxSwift/Observables/Implementations/Merge.swift b/RxSwift/Observables/Implementations/Merge.swift index 7647087a..52cb7283 100644 --- a/RxSwift/Observables/Implementations/Merge.swift +++ b/RxSwift/Observables/Implementations/Merge.swift @@ -42,7 +42,7 @@ class MergeLimitedSinkIter) -> Disposable { - let _ = _group.addDisposable(_sourceSubscription) + let _ = _group.insert(_sourceSubscription) let disposable = source.subscribe(self) _sourceSubscription.disposable = disposable @@ -96,7 +96,7 @@ class MergeLimitedSink) { let iterDisposable = SingleAssignmentDisposable() - if let disposeKey = _group.addDisposable(iterDisposable) { + if let disposeKey = _group.insert(iterDisposable) { let iter = MergeSinkIter(parent: self, disposeKey: disposeKey) let subscription = source.subscribe(iter) iterDisposable.disposable = subscription @@ -339,7 +339,7 @@ class MergeSink) -> Disposable { - let _ = _group.addDisposable(_sourceSubscription) + let _ = _group.insert(_sourceSubscription) let subscription = source.subscribe(self) _sourceSubscription.disposable = subscription diff --git a/RxSwift/Observables/Implementations/Window.swift b/RxSwift/Observables/Implementations/Window.swift index 71489391..637bfff3 100644 --- a/RxSwift/Observables/Implementations/Window.swift +++ b/RxSwift/Observables/Implementations/Window.swift @@ -31,7 +31,7 @@ class WindowTimeCountSink { let action = self._lock.calculateLocked { () -> Action? in if isAdded { - self._group.removeDisposable(removeKey!) + self._group.removeDisposable(forKey: removeKey!) } else { isDone = true @@ -65,7 +65,7 @@ class AnyRecursiveScheduler { _lock.performLocked { if !isDone { - removeKey = _group.addDisposable(d) + removeKey = _group.insert(d) isAdded = true } } @@ -90,7 +90,7 @@ class AnyRecursiveScheduler { let action = self._lock.calculateLocked { () -> Action? in if isAdded { - self._group.removeDisposable(removeKey!) + self._group.removeDisposable(forKey: removeKey!) } else { isDone = true @@ -108,7 +108,7 @@ class AnyRecursiveScheduler { _lock.performLocked { if !isDone { - removeKey = _group.addDisposable(d) + removeKey = _group.insert(d) isAdded = true } } @@ -160,7 +160,7 @@ class RecursiveImmediateScheduler { let action = self._lock.calculateLocked { () -> Action? in if isAdded { - self._group.removeDisposable(removeKey!) + self._group.removeDisposable(forKey: removeKey!) } else { isDone = true @@ -178,7 +178,7 @@ class RecursiveImmediateScheduler { _lock.performLocked { if !isDone { - removeKey = _group.addDisposable(d) + removeKey = _group.insert(d) isAdded = true } } diff --git a/RxSwift/Schedulers/VirtualTimeScheduler.swift b/RxSwift/Schedulers/VirtualTimeScheduler.swift index efd9b000..96974f90 100644 --- a/RxSwift/Schedulers/VirtualTimeScheduler.swift +++ b/RxSwift/Schedulers/VirtualTimeScheduler.swift @@ -128,7 +128,7 @@ public class VirtualTimeScheduler _schedulerQueue.enqueue(item) - _ = compositeDisposable.addDisposable(item) + _ = compositeDisposable.insert(item) return compositeDisposable } diff --git a/Tests/RxSwiftTests/Tests/DisposableTest.swift b/Tests/RxSwiftTests/Tests/DisposableTest.swift index acd55d12..58d2e3ce 100644 --- a/Tests/RxSwiftTests/Tests/DisposableTest.swift +++ b/Tests/RxSwiftTests/Tests/DisposableTest.swift @@ -73,11 +73,11 @@ class DisposableTest : RxTest { var numberDisposed = 0 let compositeDisposable = CompositeDisposable() - let result1 = compositeDisposable.addDisposable(AnonymousDisposable { + let result1 = compositeDisposable.insert(AnonymousDisposable { numberDisposed += 1 }) - _ = compositeDisposable.addDisposable(AnonymousDisposable { + _ = compositeDisposable.insert(AnonymousDisposable { numberDisposed += 1 }) @@ -89,7 +89,7 @@ class DisposableTest : RxTest { XCTAssertEqual(numberDisposed, 2) XCTAssertEqual(compositeDisposable.count, 0) - let result = compositeDisposable.addDisposable(AnonymousDisposable { + let result = compositeDisposable.insert(AnonymousDisposable { numberDisposed += 1 }) @@ -131,11 +131,11 @@ class DisposableTest : RxTest { var numberDisposed = 0 let compositeDisposable = CompositeDisposable() - let result1 = compositeDisposable.addDisposable(AnonymousDisposable { + let result1 = compositeDisposable.insert(AnonymousDisposable { numberDisposed += 1 }) - let result2 = compositeDisposable.addDisposable(AnonymousDisposable { + let result2 = compositeDisposable.insert(AnonymousDisposable { numberDisposed += 1 }) diff --git a/Tests/RxSwiftTests/Tests/Observable+ConcurrencyTest.swift b/Tests/RxSwiftTests/Tests/Observable+ConcurrencyTest.swift index 39ddf20e..2d0d50f7 100644 --- a/Tests/RxSwiftTests/Tests/Observable+ConcurrencyTest.swift +++ b/Tests/RxSwiftTests/Tests/Observable+ConcurrencyTest.swift @@ -60,7 +60,7 @@ extension ObservableConcurrencyTest { let compositeDisposable = CompositeDisposable() for test in tests { - _ = compositeDisposable.addDisposable(runDispatchQueueSchedulerTests(scheduler, tests: test)) + _ = compositeDisposable.insert(runDispatchQueueSchedulerTests(scheduler, tests: test)) } compositeDisposable.dispose()