From 1d28233ebeaa2c2b3afe1d9ea37d251dafd9ff35 Mon Sep 17 00:00:00 2001 From: Max Sokolov Date: Tue, 26 Jun 2018 22:37:40 +0300 Subject: [PATCH] meaningful associatedtype name for ConfigurableCell --- README.md | 2 +- Sources/ConfigurableCell.swift | 4 ++-- Sources/TableRow.swift | 4 ++-- Sources/TableRowAction.swift | 6 +++--- TableKit.podspec | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 4e10a91..663a157 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ Build Status Swift 4.0 compatible Carthage compatible - CocoaPods compatible + CocoaPods compatible Platform iOS License: MIT

diff --git a/Sources/ConfigurableCell.swift b/Sources/ConfigurableCell.swift index cc96430..349a401 100644 --- a/Sources/ConfigurableCell.swift +++ b/Sources/ConfigurableCell.swift @@ -22,13 +22,13 @@ import UIKit public protocol ConfigurableCell { - associatedtype T + associatedtype CellData static var reuseIdentifier: String { get } static var estimatedHeight: CGFloat? { get } static var defaultHeight: CGFloat? { get } - func configure(with _: T) + func configure(with _: CellData) } public extension ConfigurableCell where Self: UITableViewCell { diff --git a/Sources/TableRow.swift b/Sources/TableRow.swift index edfca6e..57957e7 100644 --- a/Sources/TableRow.swift +++ b/Sources/TableRow.swift @@ -22,7 +22,7 @@ import UIKit open class TableRow: Row where CellType: UITableViewCell { - open let item: CellType.T + open let item: CellType.CellData private lazy var actions = [String: [TableRowAction]]() private(set) open var editingActions: [UITableViewRowAction]? @@ -46,7 +46,7 @@ open class TableRow: Row where CellType: UITableView return CellType.self } - public init(item: CellType.T, actions: [TableRowAction]? = nil, editingActions: [UITableViewRowAction]? = nil) { + public init(item: CellType.CellData, actions: [TableRowAction]? = nil, editingActions: [UITableViewRowAction]? = nil) { self.item = item self.editingActions = editingActions diff --git a/Sources/TableRowAction.swift b/Sources/TableRowAction.swift index 73c7419..8156466 100644 --- a/Sources/TableRowAction.swift +++ b/Sources/TableRowAction.swift @@ -22,12 +22,12 @@ import UIKit open class TableRowActionOptions where CellType: UITableViewCell { - open let item: CellType.T + open let item: CellType.CellData open let cell: CellType? open let indexPath: IndexPath open let userInfo: [AnyHashable: Any]? - init(item: CellType.T, cell: CellType?, path: IndexPath, userInfo: [AnyHashable: Any]?) { + init(item: CellType.CellData, cell: CellType?, path: IndexPath, userInfo: [AnyHashable: Any]?) { self.item = item self.cell = cell @@ -76,7 +76,7 @@ open class TableRowAction where CellType: UITableVie self.handler = .action(handler) } - public func invokeActionOn(cell: UITableViewCell?, item: CellType.T, path: IndexPath, userInfo: [AnyHashable: Any]?) -> Any? { + public func invokeActionOn(cell: UITableViewCell?, item: CellType.CellData, path: IndexPath, userInfo: [AnyHashable: Any]?) -> Any? { return handler.invoke(withOptions: TableRowActionOptions(item: item, cell: cell as? CellType, path: path, userInfo: userInfo)) } diff --git a/TableKit.podspec b/TableKit.podspec index 3e2852e..a6c3ab9 100644 --- a/TableKit.podspec +++ b/TableKit.podspec @@ -2,7 +2,7 @@ Pod::Spec.new do |s| s.name = 'TableKit' s.module_name = 'TableKit' - s.version = '2.6.0' + s.version = '2.7.0' s.homepage = 'https://github.com/maxsokolov/TableKit' s.summary = 'Type-safe declarative table views with Swift.'