From 3a4554e7d5966c2a43f68821cd957e802c489fae Mon Sep 17 00:00:00 2001 From: Arseniy Borisov Date: Sat, 8 Apr 2017 16:15:17 +0300 Subject: [PATCH 1/3] add sthetho. crashlytics initialization error message. --- build.gradle | 4 +++- .../java/ru/touchin/templates/TouchinApp.java | 19 +++++++++++++++---- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/build.gradle b/build.gradle index d7fcffc..8f30817 100644 --- a/build.gradle +++ b/build.gradle @@ -44,8 +44,10 @@ dependencies { exclude group: 'org.json', module: 'json' } - provided('com.crashlytics.sdk.android:crashlytics:2.6.2@aar') { + provided('com.crashlytics.sdk.android:crashlytics:2.6.7@aar') { transitive = true; } + provided 'com.facebook.stetho:stetho:1.4.2' + } diff --git a/src/main/java/ru/touchin/templates/TouchinApp.java b/src/main/java/ru/touchin/templates/TouchinApp.java index 2bc8a83..82acdf4 100644 --- a/src/main/java/ru/touchin/templates/TouchinApp.java +++ b/src/main/java/ru/touchin/templates/TouchinApp.java @@ -29,6 +29,7 @@ import android.support.multidex.MultiDex; import android.util.Log; import com.crashlytics.android.Crashlytics; +import com.facebook.stetho.Stetho; import net.danlew.android.joda.JodaTimeAndroid; @@ -95,11 +96,21 @@ public abstract class TouchinApp extends Application { TypefacedTextView.setInDebugMode(); Lc.initialize(new ConsoleLogProcessor(LcLevel.VERBOSE), true); UiUtils.UI_LIFECYCLE_LC_GROUP.disable(); + try { + Stetho.initializeWithDefaults(this); + } catch (final NoClassDefFoundError error) { + Lc.e("Stetho initialization error! Did you forget to add stetho dependency to your build.gradle?"); + } } else { - final Crashlytics crashlytics = new Crashlytics(); - Fabric.with(this, crashlytics); - Fabric.getLogger().setLogLevel(Log.ERROR); - Lc.initialize(new CrashlyticsLogProcessor(crashlytics), false); + try { + final Crashlytics crashlytics = new Crashlytics(); + Fabric.with(this, crashlytics); + Fabric.getLogger().setLogLevel(Log.ERROR); + Lc.initialize(new CrashlyticsLogProcessor(crashlytics), false); + } catch (final NoClassDefFoundError error) { + throw new ShouldNotHappenException("Crashlytics initialization error! " + + "Did you forget to add crashlytics dependency to your build.gradle?", error); + } } } From 569ebf3ecd34b1916e6b41e42f3f53ac1a501b50 Mon Sep 17 00:00:00 2001 From: Arseniy Borisov Date: Sat, 8 Apr 2017 16:44:05 +0300 Subject: [PATCH 2/3] cr --- src/main/java/ru/touchin/templates/TouchinApp.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main/java/ru/touchin/templates/TouchinApp.java b/src/main/java/ru/touchin/templates/TouchinApp.java index 82acdf4..5994517 100644 --- a/src/main/java/ru/touchin/templates/TouchinApp.java +++ b/src/main/java/ru/touchin/templates/TouchinApp.java @@ -99,7 +99,7 @@ public abstract class TouchinApp extends Application { try { Stetho.initializeWithDefaults(this); } catch (final NoClassDefFoundError error) { - Lc.e("Stetho initialization error! Did you forget to add stetho dependency to your build.gradle?"); + Lc.e("Stetho initialization error! Did you forget to add compile 'com.facebook.stetho:stetho:+' to your build.gradle?"); } } else { try { @@ -108,8 +108,12 @@ public abstract class TouchinApp extends Application { Fabric.getLogger().setLogLevel(Log.ERROR); Lc.initialize(new CrashlyticsLogProcessor(crashlytics), false); } catch (final NoClassDefFoundError error) { - throw new ShouldNotHappenException("Crashlytics initialization error! " - + "Did you forget to add crashlytics dependency to your build.gradle?", error); + Lc.initialize(new ConsoleLogProcessor(LcLevel.INFO), false); + Lc.e("Crashlytics initialization error! Did you forget to add\n" + + "compile('com.crashlytics.sdk.android:crashlytics:+@aar') {\n" + + " transitive = true;\n" + + "}\n" + + "to your build.gradle?", error); } } } From 73cada5bc6eb732ca50650e5c661a49e363cb849 Mon Sep 17 00:00:00 2001 From: Arseniy Borisov Date: Sat, 8 Apr 2017 17:02:48 +0300 Subject: [PATCH 3/3] cr --- src/main/java/ru/touchin/templates/TouchinApp.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/ru/touchin/templates/TouchinApp.java b/src/main/java/ru/touchin/templates/TouchinApp.java index 5994517..8e29b41 100644 --- a/src/main/java/ru/touchin/templates/TouchinApp.java +++ b/src/main/java/ru/touchin/templates/TouchinApp.java @@ -99,7 +99,7 @@ public abstract class TouchinApp extends Application { try { Stetho.initializeWithDefaults(this); } catch (final NoClassDefFoundError error) { - Lc.e("Stetho initialization error! Did you forget to add compile 'com.facebook.stetho:stetho:+' to your build.gradle?"); + Lc.e("Stetho initialization error! Did you forget to add debugCompile 'com.facebook.stetho:stetho:+' to your build.gradle?"); } } else { try {