TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Invert conditional expressions that are negated. #1555 

Fixes `NegatedConditional` inspection violations.

Description:
>Reports conditional expressions whose conditions are negated. Flipping the order of the conditional expression branches will usually increase the clarity of such statements.
This commit is contained in:
Michal Kordas 2015-08-14 23:00:01 +02:00 committed by Roman Ivanov
parent 02dfe8c7c5
commit 027d1e2c99
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/com/puppycrawl/tools/checkstyle/checks/ClassResolver.java
View File

@ -121,7 +121,7 @@ public class ClassResolver {
throws ClassNotFoundException {
Class<?> clazz = null;
if (!currentClass.isEmpty()) {
final String innerClass = (!pkg.isEmpty() ? pkg + "." : "")
final String innerClass = (pkg.isEmpty() ? "" : pkg + ".")
+ currentClass + "$" + name;
if (isLoadable(innerClass)) {
clazz = safeLoad(innerClass);

2
src/main/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheck.java
View File

@ -134,7 +134,7 @@ public class TranslationCheck
final int underscoreIdx = filePath.indexOf(basenameSeparator,
baseNameStart);
final int dotIdx = filePath.indexOf('.', baseNameStart);
final int cutoffIdx = underscoreIdx != -1 ? underscoreIdx : dotIdx;
final int cutoffIdx = underscoreIdx == -1 ? dotIdx : underscoreIdx;
return filePath.substring(0, cutoffIdx);
}