From 032faf4eb469f0fff2ae1bf1a28c95b9cf5effea Mon Sep 17 00:00:00 2001
From: Roman Ivanov <ivanov-jr@mail.ru>
Date: Sun, 12 Apr 2015 23:45:56 -0700
Subject: [PATCH] fix and suppressions for Findbugs violations
 UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR. Issue #912

---
 config/findbugs-exclude.xml                      | 16 ++++++++++++++++
 .../checks/javadoc/JavadocNodeImpl.java          |  6 +++++-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/config/findbugs-exclude.xml b/config/findbugs-exclude.xml
index 49767ccf2..3bfa9b83f 100644
--- a/config/findbugs-exclude.xml
+++ b/config/findbugs-exclude.xml
@@ -87,4 +87,20 @@
       <Class name="com.puppycrawl.tools.checkstyle.api.DetailAST" />
       <Bug pattern="BC_UNCONFIRMED_CAST" />
     </Match>
+    <Match>
+      <!-- false positive, beginTree is a kind of constructor for Checks -->
+      <Or>
+        <Class name="com.puppycrawl.tools.checkstyle.checks.DeclarationCollector" />
+        <Class name="com.puppycrawl.tools.checkstyle.checks.OuterTypeFilenameCheck" />
+        <Class name="com.puppycrawl.tools.checkstyle.checks.RegexpCheck" />
+        <!-- createJavadocNode is private and can not be launched without visitToken-->
+        <Class name="com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck" />
+        <!-- has only one public method and all nitialized inthat method-->
+        <Class name="com.puppycrawl.tools.checkstyle.checks.regexp.MultilineDetector" />
+        <!-- beginProcessing() is kind of c-tor -->
+        <Class name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpMultilineCheck" />
+        <Class name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck" />
+      </Or>
+      <Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR" />
+    </Match>
 </FindBugsFilter>
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImpl.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImpl.java
index 9b352dc01..3845971e3 100644
--- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImpl.java
+++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImpl.java
@@ -93,7 +93,11 @@ public class JavadocNodeImpl implements DetailNode
     @Override
     public DetailNode[] getChildren()
     {
-        return Arrays.copyOf(children, children.length);
+        if (children == null) {
+            return children;
+        } else {
+            return Arrays.copyOf(children, children.length);
+        }
     }
 
     @Override