From 06863d123f80e8e8d558917f7a6be5a674cb6ecd Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Mon, 17 Aug 2015 22:33:34 +0200 Subject: [PATCH] Remove nested assignment. #1555 Fixes `NestedAssignment` inspection violation in test code. Description: >Reports assignment expressions nested inside other expressions. While admirably terse, such expressions may be confusing, and violate the general design principle that a given construct should do precisely one thing. --- .../google/checkstyle/test/base/ConfigurationBuilder.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/it/java/com/google/checkstyle/test/base/ConfigurationBuilder.java b/src/it/java/com/google/checkstyle/test/base/ConfigurationBuilder.java index e4a9725e7..a37b52c66 100644 --- a/src/it/java/com/google/checkstyle/test/base/ConfigurationBuilder.java +++ b/src/it/java/com/google/checkstyle/test/base/ConfigurationBuilder.java @@ -102,7 +102,11 @@ public class ConfigurationBuilder extends BaseCheckTestSupport { int lineNumber = 1; List result = new ArrayList<>(); try(BufferedReader br = new BufferedReader(new FileReader(aFileName))) { - for(String line; (line = br.readLine()) != null; ) { + while (true) { + String line = br.readLine(); + if (line == null) { + break; + } if (warnPattern.matcher(line).find()) { result.add(lineNumber); }