TouchInstinct
/
checkstyle
306
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

removed obsolete Global Property "require package html" 

and additional cleanup since that was the last boolean property
This commit is contained in:
Lars Kühne 2002-11-17 15:24:55 +00:00
parent 52d9d94ca6
commit 08f2b317d6
2 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tests/com/puppycrawl/tools/checkstyle/ConfigurationLoaderTest.java
View File

@ -85,8 +85,6 @@ public class ConfigurationLoaderTest extends TestCase
Configuration config =
loadConfiguration("override_default_configuration.xml");
assertEquals("checkstyle.tab.width", 4, config.getTabWidth());
assertTrue("checkstyle.require.packagehtml",
config.isRequirePackageHtml());
assertEquals("checkstyle.cache.file", config.getCacheFile(), "cache");
assertEquals("checkstyle.basedir", config.getBasedir(), "basedir");
assertEquals("checkstyle.locale.language",

15
src/tests/com/puppycrawl/tools/checkstyle/ConfigurationTest.java
View File

@ -24,7 +24,6 @@ public class ConfigurationTest
mProps.setProperty(Defn.BASEDIR_PROP, BASEDIR);
mProps.setProperty(Defn.CACHE_FILE_PROP, CACHE_FILE);
mProps.setProperty(Defn.TAB_WIDTH_PROP, "" + TAB_WIDTH);
mProps.setProperty(Defn.REQUIRE_PACKAGE_HTML_PROP, "true");
mGlobalProps = new GlobalProperties(mProps, System.out);
mConfig = new Configuration(mGlobalProps, new CheckConfiguration[0]);
mConfig.setClassLoader(this.getClass().getClassLoader());
@ -73,17 +72,10 @@ public class ConfigurationTest
public void testGetProperties()
{
Properties props = mConfig.getProperties();
int expectedSize = Defn.ALL_BOOLEAN_PROPS.length
+ Defn.ALL_STRING_PROPS.length
int expectedSize = Defn.ALL_STRING_PROPS.length
+ Defn.ALL_INT_PROPS.length;
assertEquals("size", expectedSize, props.size());
for (int i = 0; i < Defn.ALL_BOOLEAN_PROPS.length; i++) {
final String key = Defn.ALL_BOOLEAN_PROPS[i];
assertTrue("Missing property: " + key,
props.containsKey(key));
}
for (int i = 0; i < Defn.ALL_INT_PROPS.length; i++) {
final String key = Defn.ALL_INT_PROPS[i];
assertTrue("Missing property: " + key,
@ -101,9 +93,4 @@ public class ConfigurationTest
{
assertEquals(TAB_WIDTH, mConfig.getTabWidth());
}
public void testIsRequirePackageHtml()
{
assertTrue(mConfig.isRequirePackageHtml());
}
}