From 15c91c8ec20f1349e6f8eea2beb16e922bb03a89 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Mon, 17 Aug 2015 23:03:22 +0200 Subject: [PATCH] Add missing toString() methods. #1555 Fixes `ObjectToString` inspection violations. Description: >Reports any calls to .toString() which use the default implementation from java.lang.Object. The default implementation is rarely desired, but easy to use by accident. Calls to .toString() on objects of type java.lang.Object are ignored by this inspection. --- src/main/java/com/puppycrawl/tools/checkstyle/TreeWalker.java | 2 +- .../tools/checkstyle/checks/AbstractTypeAwareCheck.java | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/TreeWalker.java b/src/main/java/com/puppycrawl/tools/checkstyle/TreeWalker.java index 748f8fa15..8cd470742 100755 --- a/src/main/java/com/puppycrawl/tools/checkstyle/TreeWalker.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/TreeWalker.java @@ -266,7 +266,7 @@ public final class TreeWalker else { throw new CheckstyleException("Token \"" + token + "\" was not found in Acceptable tokens list" - + " in check " + check); + + " in check " + check.getClass().getName()); } } } diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/AbstractTypeAwareCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/AbstractTypeAwareCheck.java index 38823a8f4..165bbbffc 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/AbstractTypeAwareCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/AbstractTypeAwareCheck.java @@ -491,8 +491,7 @@ public abstract class AbstractTypeAwareCheck extends Check { @Override public String toString() { - return "ClassAlias[alias " + getName() - + " for " + classInfo + "]"; + return "ClassAlias[alias " + getName() + " for " + classInfo.getName() + "]"; } }