TouchInstinct
/
checkstyle
311
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename suspicious getters and setters. #1555 

Fixes `SuspiciousGetterSetter` inspection violations.

Description:
>Reports suspicious getter or setter methods. A getter or setter is suspicious if it accesses a different field than would be expected by its name.
This commit is contained in:
Michal Kordas 2015-08-27 17:37:45 +02:00 committed by Roman Ivanov
parent 4d2e6647f9
commit 1b765f3c22
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocParagraphCheck.java
View File

@ -35,7 +35,7 @@ import com.puppycrawl.tools.checkstyle.utils.JavadocUtils;
* </ul>
*
* <p>
* The check can be specified by option tagImmediatelyBeforeFirstWord,
* The check can be specified by option allowNewlineParagraph,
* which says whether the &lt;p&gt; tag should be placed immediately before
* the first word.
*
@ -50,13 +50,13 @@ import com.puppycrawl.tools.checkstyle.utils.JavadocUtils;
* To allow newlines and spaces immediately after the &lt;p&gt; tag:
* <pre>
* &lt;module name=&quot;JavadocParagraph&quot;&gt;
* &lt;property name=&quot;tagImmediatelyBeforeFirstWord&quot;
* &lt;property name=&quot;allowNewlineParagraph&quot;
* value==&quot;false&quot;/&gt;
* &lt;/module&quot;&gt;
* </pre>
*
* <p>
* In case of tagImmediatelyBeforeFirstWord set to false
* In case of allowNewlineParagraph set to false
* the following example will not have any violations:
* <pre>
* /**
@ -105,14 +105,14 @@ public class JavadocParagraphCheck extends AbstractJavadocCheck {
/**
* Whether the &lt;p&gt; tag should be placed immediately before the first word.
*/
private boolean tagImmediatelyBeforeFirstWord = true;
private boolean allowNewlineParagraph = true;
/**
* Sets tagImmediatelyBeforeFirstWord.
* Sets allowNewlineParagraph.
* @param value value to set.
*/
public void setAllowNewlineParagraph(boolean value) {
tagImmediatelyBeforeFirstWord = value;
allowNewlineParagraph = value;
}
@Override
@ -167,7 +167,7 @@ public class JavadocParagraphCheck extends AbstractJavadocCheck {
else if (newLine == null || tag.getLineNumber() - newLine.getLineNumber() != 1) {
log(tag.getLineNumber(), MSG_LINE_BEFORE);
}
if (tagImmediatelyBeforeFirstWord && isImmediatelyFollowedByText(tag)) {
if (allowNewlineParagraph && isImmediatelyFollowedByText(tag)) {
log(tag.getLineNumber(), MSG_MISPLACED_TAG);
}
}

6
src/main/java/com/puppycrawl/tools/checkstyle/checks/metrics/JavaNCSSCheck.java
View File

@ -372,13 +372,13 @@ public class JavaNCSSCheck extends Check {
*/
private static class Counter {
/** The counters internal integer */
private int ivCount;
private int count;
/**
* Increments the counter.
*/
public void increment() {
ivCount++;
count++;
}
/**
@ -387,7 +387,7 @@ public class JavaNCSSCheck extends Check {
* @return the counter
*/
public int getCount() {
return ivCount;
return count;
}
}
}