TouchInstinct
/
checkstyle
311
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed 852397 (checkstyle frames lacks summary link) 

Fixed problem in IllegalType check reported by Venkatesh Prasad Ranganath.
Fixed checkstyle.style target in build.xml.
This commit is contained in:
Oleg Sukhodolsky 2003-12-05 04:41:21 +00:00
parent 9e5fccda3a
commit 204c472399
5 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
build.xml
View File

@ -275,6 +275,8 @@
<classpath refid="run.classpath"/>
<property key="checkstyle.cache.file" file="target/cachefile"/>
<property key="checkstyle.header.file" file="docs/java.header"/>
<property key="checkstyle.suppressions.file"
file="docs/suppressions.xml"/>
</checkstyle>
<mkdir dir="target/style/frames"/>
<mkdir dir="target/style/noframes"/>

1
contrib/checkstyle-frames.xsl
View File

@ -207,6 +207,7 @@
</head>
<body>
<h2>Files</h2>
<p><a href="overview-frame.html" target="fileFrame">Summary</a></p>
<p>
<table width="100%">
<!-- For each file create its part -->

7
docs/releasenotes.html
View File

@ -103,8 +103,11 @@
<li class="body">xmllogger.dtd is out-of-date
(bug 847974).</li>
<li class="body">ArrayTypeStyle shouldn't check method definition
(bug 849450).</li>
<li class="body">ArrayTypeStyle shouldn't check method definition
(bug 849450).</li>
<li class="body">Added link to summary page in
checkstyle-frames.xsl (bug 852397).</li>
</ul>
<a name="release3_2"></a>

2
src/checkstyle/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheck.java
View File

@ -221,7 +221,7 @@ public final class IllegalTypeCheck extends AbstractFormatCheck
{
mIgnoredMethodNames.clear();
for (int i = 0; i < aMethodNames.length; i++) {
mIllegalClassNames.add(aMethodNames[i]);
mIgnoredMethodNames.add(aMethodNames[i]);
}
}

15
src/tests/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheckTest.java
View File

@ -20,4 +20,19 @@ public class IllegalTypeCheckTest extends BaseCheckTestCase {
verify(checkConfig, getPath("coding" + File.separator + "InputIllegalType.java"), expected);
}
public void testIgnoreMethodNames() throws Exception {
DefaultConfiguration checkConfig = createCheckConfig(IllegalTypeCheck.class);
checkConfig.addAttribute("ignoredMethodNames", "table2");
String[] expected = {
"6:13: Declaring variables, return values or parameters of type 'AbstractClass' is not allowed.",
"9:13: Declaring variables, return values or parameters of type "
+ "'au.com.redhillconsulting.jamaica.tools.checkstyle.InputIllegalType.AbstractClass'"
+ " is not allowed.",
"16:13: Declaring variables, return values or parameters of type 'java.util.Hashtable' is not allowed.",
};
verify(checkConfig, getPath("coding" + File.separator + "InputIllegalType.java"), expected);
}
}