diff --git a/pom.xml b/pom.xml index 8f51077b3..7d239a47c 100644 --- a/pom.xml +++ b/pom.xml @@ -1190,7 +1190,6 @@ .*.checks.naming.AbstractAccessControlNameCheck9580 .*.checks.naming.AbstractClassNameCheck10090 .*.checks.naming.AbstractNameCheck10087 - .*.checks.naming.AbstractTypeParameterNameCheck7581 .*.checks.regexp.CommentSuppressor75100 .*.checks.regexp.DetectorOptions10096 diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/AbstractTypeParameterNameCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/AbstractTypeParameterNameCheck.java index 56c3a47d5..40441e7c4 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/AbstractTypeParameterNameCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/AbstractTypeParameterNameCheck.java @@ -34,8 +34,6 @@ import com.puppycrawl.tools.checkstyle.api.TokenTypes; */ public abstract class AbstractTypeParameterNameCheck extends AbstractNameCheck { - /** the location of the type parameter **/ - private int location; /** * Creates a new AbstractTypeParameterNameCheck instance. @@ -59,21 +57,11 @@ public abstract class AbstractTypeParameterNameCheck }; } - @Override - public final void init() { - this.location = getLocation(); - } - @Override protected final boolean mustCheckName(DetailAST ast) { - DetailAST location = + final DetailAST location = ast.getParent().getParent(); - - if (location.getType() == TokenTypes.MODIFIERS) { - location = location.getParent(); - } - - return location.getType() == this.location; + return location.getType() == getLocation(); } /** diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeParameterNameTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeParameterNameTest.java index 124f24729..076ba23f9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeParameterNameTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeParameterNameTest.java @@ -19,14 +19,16 @@ package com.puppycrawl.tools.checkstyle.checks.naming; +import static com.puppycrawl.tools.checkstyle.checks.naming.AbstractNameCheck.MSG_INVALID_PATTERN; + import java.io.File; +import org.junit.Assert; import org.junit.Test; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; import com.puppycrawl.tools.checkstyle.DefaultConfiguration; - -import static com.puppycrawl.tools.checkstyle.checks.naming.AbstractNameCheck.MSG_INVALID_PATTERN; +import com.puppycrawl.tools.checkstyle.api.TokenTypes; public class TypeParameterNameTest extends BaseCheckTestSupport { @@ -130,4 +132,15 @@ public class TypeParameterNameTest }; verify(checkConfig, getPath("naming" + File.separator + "InputTypeParameterName.java"), expected); } + + @Test + public void testGetAcceptableTokens() { + AbstractTypeParameterNameCheck typeParameterNameCheckObj = new ClassTypeParameterNameCheck(); + int[] actual = typeParameterNameCheckObj.getAcceptableTokens(); + int[] expected = new int[] { + TokenTypes.TYPE_PARAMETER, + }; + Assert.assertNotNull(actual); + Assert.assertArrayEquals(expected, actual); + } }