From 24d8ecc0aeb8e55eee83a0eabe34c67027400680 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Sat, 1 Aug 2015 21:18:08 +0200 Subject: [PATCH] Return expression without assigning it to temporary variable. #46 Fixes squid:S1488 violation. --- .../checkstyle/checks/design/VisibilityModifierCheck.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java index 63bb344b5..ec323eafd 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java @@ -733,10 +733,9 @@ public class VisibilityModifierCheck * @return short name of class. */ private static String getClassShortName(String canonicalClassName) { - final String shortClassName = canonicalClassName + return canonicalClassName .substring(canonicalClassName.lastIndexOf('.') + 1, canonicalClassName.length()); - return shortClassName; } /**