From 26ffb0af87d8718dd58344d6a95df477fa66f380 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Wed, 12 Aug 2015 23:16:56 +0200 Subject: [PATCH] Change name of private method conflicting with superclass method. #1555 Fixes `MethodOverridesPrivateMethod` inspection violations. Description: >Reports instance methods having the same name as a private method of a superclass. Such methods may result in confusing semantics, particularly if the private method is ever made publicly visible. --- .../checkstyle/checks/indentation/ArrayInitHandler.java | 6 +++--- .../checkstyle/checks/indentation/ObjectBlockHandler.java | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java index f2b01c1e0..347bf68b7 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java @@ -68,7 +68,7 @@ public class ArrayInitHandler extends BlockParentHandler { @Override protected IndentLevel curlyLevel() { final IndentLevel level = new IndentLevel(getLevel(), getBraceAdjustment()); - level.addAcceptedIndent(level.getLastIndentLevel() + getLineWrappingIndent()); + level.addAcceptedIndent(level.getLastIndentLevel() + getLineWrappingIndentation()); return level; } @@ -104,7 +104,7 @@ public class ArrayInitHandler extends BlockParentHandler { getNextFirstNonblankOnLineAfter(firstLine, lcurlyPos); if (firstChildPos >= 0) { expectedIndent.addAcceptedIndent(firstChildPos); - expectedIndent.addAcceptedIndent(lcurlyPos + getLineWrappingIndent()); + expectedIndent.addAcceptedIndent(lcurlyPos + getLineWrappingIndentation()); } return expectedIndent; } @@ -134,7 +134,7 @@ public class ArrayInitHandler extends BlockParentHandler { * @return value of lineWrappingIndentation property * of {@code IndentationCheck} */ - private int getLineWrappingIndent() { + private int getLineWrappingIndentation() { return getIndentCheck().getLineWrappingIndentation(); } } diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ObjectBlockHandler.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ObjectBlockHandler.java index 0dafad951..3f8da688e 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ObjectBlockHandler.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ObjectBlockHandler.java @@ -93,7 +93,7 @@ public class ObjectBlockHandler extends BlockParentHandler { final DetailAST rcurly = getRCurly(); final int rcurlyPos = expandedTabsColumnNo(rcurly); final IndentLevel level = curlyLevel(); - level.addAcceptedIndent(level.getFirstIndentLevel() + getLineWrappingIndent()); + level.addAcceptedIndent(level.getFirstIndentLevel() + getLineWrappingIndentation()); if (!level.accept(rcurlyPos) && startsLine(rcurly)) { logError(rcurly, "rcurly", rcurlyPos, curlyLevel()); @@ -105,7 +105,7 @@ public class ObjectBlockHandler extends BlockParentHandler { * @return value of lineWrappingIndentation property * of {@code IndentationCheck} */ - private int getLineWrappingIndent() { + private int getLineWrappingIndentation() { return getIndentCheck().getLineWrappingIndentation(); } }