diff --git a/pom.xml b/pom.xml
index b68dd6f56..91a1d6211 100644
--- a/pom.xml
+++ b/pom.xml
@@ -871,7 +871,6 @@
.*.checks.naming.AbstractClassNameCheck10090
.*.checks.naming.AbstractNameCheck10087
.*.checks.naming.AbstractTypeParameterNameCheck7581
- .*.checks.naming.ConstantNameCheck8892
.*.checks.regexp.CommentSuppressor75100
.*.checks.regexp.DetectorOptions10096
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheck.java
index 7c1821be6..b64b1ef97 100644
--- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheck.java
+++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheck.java
@@ -76,10 +76,8 @@ public class ConstantNameCheck
final DetailAST modifiersAST =
ast.findFirstToken(TokenTypes.MODIFIERS);
- final boolean isStatic = modifiersAST != null
- && modifiersAST.branchContains(TokenTypes.LITERAL_STATIC);
- final boolean isFinal = modifiersAST != null
- && modifiersAST.branchContains(TokenTypes.FINAL);
+ final boolean isStatic = modifiersAST.branchContains(TokenTypes.LITERAL_STATIC);
+ final boolean isFinal = modifiersAST.branchContains(TokenTypes.FINAL);
if (isStatic && isFinal && shouldCheckInScope(modifiersAST)
|| ScopeUtils.inAnnotationBlock(ast)
@@ -88,8 +86,7 @@ public class ConstantNameCheck
// Handle the serialVersionUID and serialPersistentFields constants
// which are used for Serialization. Cannot enforce rules on it. :-)
final DetailAST nameAST = ast.findFirstToken(TokenTypes.IDENT);
- if (nameAST != null
- && !"serialVersionUID".equals(nameAST.getText())
+ if (!"serialVersionUID".equals(nameAST.getText())
&& !"serialPersistentFields".equals(nameAST.getText())) {
retVal = true;
}
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheckTest.java
index 04478dc8d..dd3516a7c 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheckTest.java
@@ -19,14 +19,18 @@
package com.puppycrawl.tools.checkstyle.checks.naming;
+import static com.puppycrawl.tools.checkstyle.checks.naming.AbstractNameCheck.MSG_INVALID_PATTERN;
import static org.junit.Assert.fail;
+
+import java.io.File;
+
+import org.junit.Assert;
+import org.junit.Test;
+
import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
import com.puppycrawl.tools.checkstyle.api.CheckstyleException;
-import java.io.File;
-import org.junit.Test;
-
-import static com.puppycrawl.tools.checkstyle.checks.naming.AbstractNameCheck.MSG_INVALID_PATTERN;
+import com.puppycrawl.tools.checkstyle.api.TokenTypes;
public class ConstantNameCheckTest
extends BaseCheckTestSupport {
@@ -134,4 +138,15 @@ public class ConstantNameCheckTest
+ "checkstyle/InputStaticModifierInInterface.java").getCanonicalPath(),
expected);
}
+
+ @Test
+ public void testGetAcceptableTokens() {
+ ConstantNameCheck constantNameCheckObj = new ConstantNameCheck();
+ int[] actual = constantNameCheckObj.getAcceptableTokens();
+ int[] expected = new int[] {
+ TokenTypes.VARIABLE_DEF,
+ };
+ Assert.assertNotNull(actual);
+ Assert.assertArrayEquals(expected, actual);
+ }
}