From 302f80bd65e3670d296bba40de712be7a0932bd3 Mon Sep 17 00:00:00 2001 From: Oliver Burn Date: Sun, 2 Jul 2006 10:41:29 +0000 Subject: [PATCH] Just fix an annoying error where assigning to a parameter. --- .../tools/checkstyle/api/AutomaticBean.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/api/AutomaticBean.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/api/AutomaticBean.java index 140f81aaf..2faaa90f0 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/api/AutomaticBean.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/api/AutomaticBean.java @@ -402,7 +402,7 @@ final class StrArrayConverter extends AbstractArrayConverter * @throws NullPointerException * if svalue is null */ - protected List parseElements(String aValue) + protected List parseElements(final String aValue) throws NullPointerException { // Validate the passed argument @@ -411,13 +411,12 @@ final class StrArrayConverter extends AbstractArrayConverter } // Trim any matching '{' and '}' delimiters - aValue = aValue.trim(); - - if (aValue.startsWith("{") && aValue.endsWith("}")) { - aValue = aValue.substring(1, aValue.length() - 1); + String str = aValue.trim(); + if (str.startsWith("{") && str.endsWith("}")) { + str = str.substring(1, str.length() - 1); } - final StringTokenizer st = new StringTokenizer(aValue, ","); + final StringTokenizer st = new StringTokenizer(str, ","); final List retVal = new ArrayList(); while (st.hasMoreTokens()) {