From 3090cf0dab48c9119becc1f4fcd65c625119bfad Mon Sep 17 00:00:00 2001
From: Thomas Jensen <tsjensen@users.noreply.github.com>
Date: Fri, 12 Jun 2015 20:18:18 +0200
Subject: [PATCH] FileContents.getFileName() - resolve issue #1205

---
 config/findbugs-exclude.xml                            |  8 ++++++++
 pom.xml                                                |  2 +-
 .../puppycrawl/tools/checkstyle/api/FileContents.java  | 10 ++++++++++
 3 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/config/findbugs-exclude.xml b/config/findbugs-exclude.xml
index 67a01f22a..6e4636f25 100644
--- a/config/findbugs-exclude.xml
+++ b/config/findbugs-exclude.xml
@@ -73,6 +73,14 @@
       <Class name="com.puppycrawl.tools.checkstyle.api.DetailAST" />
       <Bug pattern="BC_UNCONFIRMED_CAST" />
     </Match>
+    <Match>
+      <!-- Support both getFileName() and getFilename() -->
+      <and>
+        <Class name="com.puppycrawl.tools.checkstyle.api.FileContents" />
+        <Method name="~setFile[nN]ame" />
+      </and>
+      <Bug pattern="NM_CONFUSING" />
+    </Match>
     <Match>
       <!-- false positive, beginTree is a kind of constructor for Checks -->
       <Or>
diff --git a/pom.xml b/pom.xml
index 3fa6d9acb..f1b8d186d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -717,7 +717,7 @@
           <regex><pattern>.*.api.Check</pattern><branchRate>100</branchRate><lineRate>86</lineRate></regex>
           <regex><pattern>.*.api.Comment</pattern><branchRate>100</branchRate><lineRate>95</lineRate></regex>
           <regex><pattern>.*.api.DetailAST</pattern><branchRate>95</branchRate><lineRate>98</lineRate></regex>
-          <regex><pattern>.*.api.FileContents</pattern><branchRate>96</branchRate><lineRate>94</lineRate></regex>
+          <regex><pattern>.*.api.FileContents</pattern><branchRate>96</branchRate><lineRate>93</lineRate></regex>
           <regex><pattern>.*.api.FileText</pattern><branchRate>50</branchRate><lineRate>59</lineRate></regex>
           <regex><pattern>.*.api.FullIdent</pattern><branchRate>83</branchRate><lineRate>96</lineRate></regex>
           <regex><pattern>.*.api.JavadocTagInfo</pattern><branchRate>25</branchRate><lineRate>77</lineRate></regex>
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/api/FileContents.java b/src/main/java/com/puppycrawl/tools/checkstyle/api/FileContents.java
index a1a55d67b..589cc87fb 100644
--- a/src/main/java/com/puppycrawl/tools/checkstyle/api/FileContents.java
+++ b/src/main/java/com/puppycrawl/tools/checkstyle/api/FileContents.java
@@ -251,6 +251,16 @@ public final class FileContents implements CommentListener {
         return fileName;
     }
 
+    /**
+     * Getter.
+     * @return the name of the file
+     * @deprecated use {@link #getFileName} instead
+     */
+    @Deprecated
+    public String getFilename() {
+        return getFileName();
+    }
+
     /**
      * Checks if the specified line is blank.
      * @param lineNo the line number to check