TouchInstinct
/
checkstyle
305
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #46: loops should not have more then one break or continue statement

This commit is contained in:
Ilja Dubinin 2015-09-05 11:59:17 +01:00
parent a3b229b5d8
commit 33ab409c4e
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheck.java
View File

@ -23,6 +23,7 @@ import java.util.Set;
import java.util.StringTokenizer;
import antlr.collections.AST;
import com.google.common.collect.Sets;
import com.puppycrawl.tools.checkstyle.api.Check;
import com.puppycrawl.tools.checkstyle.api.DetailAST;
@ -263,24 +264,15 @@ public class IllegalInstantiationCheck
String illegalType = null;
// import statements
for (FullIdent importLineText : imports) {
final String importArg = importLineText.getText();
String importArg = importLineText.getText();
if (importArg.endsWith(".*")) {
final String fqClass =
importArg.substring(0, importArg.length() - 1)
+ className;
// assume that illegalInstances only contain existing classes
// or else we might create a false alarm here
if (illegalClasses.contains(fqClass)) {
illegalType = fqClass;
break;
}
importArg = importArg.substring(0, importArg.length() - 1)
+ className;
}
else {
if (CommonUtils.baseClassName(importArg).equals(className)
if (CommonUtils.baseClassName(importArg).equals(className)
&& illegalClasses.contains(importArg)) {
illegalType = importArg;
break;
}
illegalType = importArg;
break;
}
}
return illegalType;