TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #1289: 'AbstractParenPadCheck' UT coverage improved

This commit is contained in:
Ruslan Diachenko 2015-07-26 03:20:32 +01:00 committed by Roman Ivanov
parent b219e2ff88
commit 33efb558db
4 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pom.xml
View File

@ -1152,8 +1152,6 @@
<regex><pattern>.*.checks.regexp.RegexpSinglelineCheck</pattern><branchRate>100</branchRate><lineRate>76</lineRate></regex>
<regex><pattern>.*.checks.regexp.SinglelineDetector</pattern><branchRate>93</branchRate><lineRate>96</lineRate></regex>
<regex><pattern>.*.checks.whitespace.AbstractParenPadCheck</pattern><branchRate>88</branchRate><lineRate>100</lineRate></regex>
<regex><pattern>.*.filters.SuppressionCommentFilter</pattern><branchRate>83</branchRate><lineRate>93</lineRate></regex>
<regex><pattern>.*.filters.SuppressionCommentFilter\$Tag</pattern><branchRate>96</branchRate><lineRate>94</lineRate></regex>
<regex><pattern>.*.filters.SuppressionsLoader</pattern><branchRate>63</branchRate><lineRate>77</lineRate></regex>

1
src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoWhitespaceBeforeCheckTest.java
View File

@ -49,6 +49,7 @@ public class NoWhitespaceBeforeCheckTest
"211:15: " + getCheckMessage(MSG_KEY, ";"),
"266:1: " + getCheckMessage(MSG_KEY, ";"),
"270:15: " + getCheckMessage(MSG_KEY, ";"),
"284:1: " + getCheckMessage(MSG_KEY, ";"),
};
verify(checkConfig, getPath("InputWhitespace.java"), expected);
}

16
src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/ParenPadCheckTest.java
View File

@ -44,8 +44,8 @@ public class ParenPadCheckTest
"232:27: " + getCheckMessage(WS_PRECEDED, ")"),
"241:24: " + getCheckMessage(WS_FOLLOWED, "("),
"241:30: " + getCheckMessage(WS_PRECEDED, ")"),
"276:18: " + getCheckMessage(WS_FOLLOWED, "("),
"276:23: " + getCheckMessage(WS_PRECEDED, ")"),
"277:18: " + getCheckMessage(WS_FOLLOWED, "("),
"277:23: " + getCheckMessage(WS_PRECEDED, ")"),
};
verify(checkConfig, getPath("InputWhitespace.java"), expected);
}
@ -84,12 +84,12 @@ public class ParenPadCheckTest
"235:39: " + getCheckMessage(WS_NOT_PRECEDED, ")"),
"252:21: " + getCheckMessage(WS_NOT_FOLLOWED, "("),
"252:93: " + getCheckMessage(WS_NOT_PRECEDED, ")"),
"272:26: " + getCheckMessage(WS_NOT_FOLLOWED, "("),
"272:36: " + getCheckMessage(WS_NOT_PRECEDED, ")"),
"274:29: " + getCheckMessage(WS_NOT_FOLLOWED, "("),
"274:42: " + getCheckMessage(WS_NOT_PRECEDED, ")"),
"275:18: " + getCheckMessage(WS_NOT_FOLLOWED, "("),
"275:33: " + getCheckMessage(WS_NOT_PRECEDED, ")"),
"273:26: " + getCheckMessage(WS_NOT_FOLLOWED, "("),
"273:36: " + getCheckMessage(WS_NOT_PRECEDED, ")"),
"275:29: " + getCheckMessage(WS_NOT_FOLLOWED, "("),
"275:42: " + getCheckMessage(WS_NOT_PRECEDED, ")"),
"276:18: " + getCheckMessage(WS_NOT_FOLLOWED, "("),
"276:33: " + getCheckMessage(WS_NOT_PRECEDED, ")"),
};
verify(checkConfig, getPath("InputWhitespace.java"), expected);
}

10
src/test/resources/com/puppycrawl/tools/checkstyle/InputWhitespace.java
View File

@ -269,10 +269,18 @@ class SpecialCasesInForLoop
public void testNullSemi() {
return ;
}
public void register(Object obj) { }
public void doSomething(String args[]) {
register(boolean[].class);
register( args );
}
}
public void parentheses() {
testNullSemi
(
)
;
}
}