diff --git a/pom.xml b/pom.xml index 4e9849b12..ef304f788 100644 --- a/pom.xml +++ b/pom.xml @@ -1144,7 +1144,6 @@ .*.checks.javadoc.JavadocMethodCheck9198 .*.checks.javadoc.JavadocParagraphCheck92100 .*.checks.javadoc.JavadocStyleCheck8998 - .*.checks.javadoc.JavadocTypeCheck9593 .*.checks.javadoc.JavadocUtils94100 .*.checks.javadoc.TagParser9298 .*.checks.javadoc.WriteTagCheck10091 diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java index f69f0ed18..5df77a00d 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java @@ -295,7 +295,6 @@ public class JavadocTypeCheck for (int i = tags.size() - 1; i >= 0; i--) { final JavadocTag tag = tags.get(i); if (tag.isParamTag() - && tag.getArg1() != null && tag.getArg1().indexOf("<" + typeParamName + ">") == 0) { found = true; } @@ -319,28 +318,14 @@ public class JavadocTypeCheck final JavadocTag tag = tags.get(i); if (tag.isParamTag()) { - if (tag.getArg1() != null) { - - final Matcher matcher = pattern.matcher(tag.getArg1()); - String typeParamName = null; - - if (matcher.matches()) { - typeParamName = matcher.group(1).trim(); - if (!typeParamNames.contains(typeParamName)) { - log(tag.getLineNo(), tag.getColumnNo(), - UNUSED_TAG, - JavadocTagInfo.PARAM.getText(), - "<" + typeParamName + ">"); - } - } - else { - log(tag.getLineNo(), tag.getColumnNo(), - UNUSED_TAG_GENERAL); - } - } - else { + final Matcher matcher = pattern.matcher(tag.getArg1()); + matcher.find(); + final String typeParamName = matcher.group(1).trim(); + if (!typeParamNames.contains(typeParamName)) { log(tag.getLineNo(), tag.getColumnNo(), - UNUSED_TAG_GENERAL); + UNUSED_TAG, + JavadocTagInfo.PARAM.getText(), + "<" + typeParamName + ">"); } } }