From 3abc77ef3b19145625806f436ab2e9db1db08d2b Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Sat, 8 Aug 2015 13:47:46 +0200 Subject: [PATCH] Hide package-visible instance fields. #1555 Fixes `PackageVisibleField` inspection violation. Description: >Reports package-visible instance variables. Constants (i.e. variables marked static and final) are not reported. --- .../java/com/puppycrawl/tools/checkstyle/gui/Main.java | 8 ++++++-- .../tools/checkstyle/gui/ParseTreeInfoPanel.java | 6 +++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/gui/Main.java b/src/main/java/com/puppycrawl/tools/checkstyle/gui/Main.java index 6e960de58..af1eb07c2 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/gui/Main.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/gui/Main.java @@ -34,7 +34,7 @@ public class Main { /** * Main frame */ - static JFrame frame; + private static JFrame frame; /** * Entry point @@ -68,6 +68,10 @@ public class Main { frame.setVisible(true); } + static JFrame getFrame() { + return frame; + } + /** * http://findbugs.sourceforge.net/bugDescriptions.html#SW_SWING_METHODS_INVOKED_IN_SWING_THREAD */ @@ -75,7 +79,7 @@ public class Main { /** * frame */ - final JFrame frame; + private final JFrame frame; /** * contstructor diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/gui/ParseTreeInfoPanel.java b/src/main/java/com/puppycrawl/tools/checkstyle/gui/ParseTreeInfoPanel.java index 7eed2362b..3f536fec6 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/gui/ParseTreeInfoPanel.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/gui/ParseTreeInfoPanel.java @@ -163,7 +163,7 @@ public class ParseTreeInfoPanel extends JPanel { public void openFile(File file, final Component parent) { if (file != null) { try { - Main.frame.setTitle("Checkstyle : " + file.getName()); + Main.getFrame().setTitle("Checkstyle : " + file.getName()); final FileText text = new FileText(file.getAbsoluteFile(), getEncoding()); final DetailAST parseTree = parseFile(text); @@ -298,12 +298,12 @@ public class ParseTreeInfoPanel extends JPanel { /** * frame */ - final Component parent; + private final Component parent; /** * frame */ - final String msg; + private final String msg; /** * contstructor