From 42fc689da0fd2f8b9d6e1ea42da65479f5ad9121 Mon Sep 17 00:00:00 2001 From: Vladlis Date: Tue, 12 May 2015 19:47:18 +0300 Subject: [PATCH] test coverage for getRequiredTokens() and getAcceptableTokens(), #1009 --- .../design/DesignForExtensionCheckTest.java | 9 +++++++++ .../checks/design/FinalClassCheckTest.java | 10 ++++++++++ .../HideUtilityClassConstructorCheckTest.java | 10 ++++++++++ .../checks/design/InnerTypeLastCheckTest.java | 10 ++++++++++ .../design/InterfaceIsTypeCheckTest.java | 17 +++++++++++++++++ .../design/MutableExceptionCheckTest.java | 18 ++++++++++++++++++ .../checks/design/ThrowsCountCheckTest.java | 19 +++++++++++++++++++ .../design/VisibilityModifierCheckTest.java | 14 ++++++++++++++ 8 files changed, 107 insertions(+) diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/DesignForExtensionCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/DesignForExtensionCheckTest.java index 50abce62b..543e50691 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/DesignForExtensionCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/DesignForExtensionCheckTest.java @@ -21,9 +21,11 @@ package com.puppycrawl.tools.checkstyle.checks.design; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; import com.puppycrawl.tools.checkstyle.DefaultConfiguration; +import com.puppycrawl.tools.checkstyle.api.TokenTypes; import org.junit.Test; import static com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck.MSG_KEY; +import static org.junit.Assert.assertArrayEquals; public class DesignForExtensionCheckTest extends BaseCheckTestSupport @@ -41,4 +43,11 @@ public class DesignForExtensionCheckTest } + @Test + public void testGetAcceptableTokens() + { + DesignForExtensionCheck obj = new DesignForExtensionCheck(); + int[] expected = {TokenTypes.METHOD_DEF}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java index 68848974c..6f4255b4b 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java @@ -21,9 +21,11 @@ package com.puppycrawl.tools.checkstyle.checks.design; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; import com.puppycrawl.tools.checkstyle.DefaultConfiguration; +import com.puppycrawl.tools.checkstyle.api.TokenTypes; import org.junit.Test; import static com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck.MSG_KEY; +import static org.junit.Assert.assertArrayEquals; public class FinalClassCheckTest extends BaseCheckTestSupport @@ -40,4 +42,12 @@ public class FinalClassCheckTest }; verify(checkConfig, getPath("InputFinalClass.java"), expected); } + + @Test + public void testGetAcceptableTokens() + { + FinalClassCheck obj = new FinalClassCheck(); + int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.CTOR_DEF}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java index 98e52c638..7883a8f7f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java @@ -22,10 +22,13 @@ package com.puppycrawl.tools.checkstyle.checks.design; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; import com.puppycrawl.tools.checkstyle.DefaultConfiguration; import java.io.File; + +import com.puppycrawl.tools.checkstyle.api.TokenTypes; import org.junit.Test; import static com.puppycrawl.tools.checkstyle.checks.design.HideUtilityClassConstructorCheck .MSG_KEY; +import static org.junit.Assert.assertArrayEquals; public class HideUtilityClassConstructorCheckTest extends BaseCheckTestSupport @@ -103,4 +106,11 @@ public class HideUtilityClassConstructorCheckTest verify(checkConfig, getPath("design" + File.separator + "HideUtilityClassContructor3041574_3.java"), expected); } + @Test + public void testGetAcceptableTokens() + { + HideUtilityClassConstructorCheck obj = new HideUtilityClassConstructorCheck(); + int[] expected = {TokenTypes.CLASS_DEF}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InnerTypeLastCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InnerTypeLastCheckTest.java index 68cec330d..12a9b62f0 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InnerTypeLastCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InnerTypeLastCheckTest.java @@ -21,11 +21,13 @@ package com.puppycrawl.tools.checkstyle.checks.design; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; import com.puppycrawl.tools.checkstyle.DefaultConfiguration; +import com.puppycrawl.tools.checkstyle.api.TokenTypes; import org.junit.Test; import java.io.File; import static com.puppycrawl.tools.checkstyle.checks.design.InnerTypeLastCheck.MSG_KEY; +import static org.junit.Assert.assertArrayEquals; public class InnerTypeLastCheckTest extends BaseCheckTestSupport { @@ -44,4 +46,12 @@ public class InnerTypeLastCheckTest extends BaseCheckTestSupport verify(checkConfig, getPath("design" + File.separator + "InputInnerClassCheck.java"), expected); } + + @Test + public void testGetAcceptableTokens() + { + InnerTypeLastCheck obj = new InnerTypeLastCheck(); + int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InterfaceIsTypeCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InterfaceIsTypeCheckTest.java index bc77fde25..a943794c0 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InterfaceIsTypeCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InterfaceIsTypeCheckTest.java @@ -21,9 +21,11 @@ package com.puppycrawl.tools.checkstyle.checks.design; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; import com.puppycrawl.tools.checkstyle.DefaultConfiguration; +import com.puppycrawl.tools.checkstyle.api.TokenTypes; import org.junit.Test; import static com.puppycrawl.tools.checkstyle.checks.design.InterfaceIsTypeCheck.MSG_KEY; +import static org.junit.Assert.assertArrayEquals; public class InterfaceIsTypeCheckTest extends BaseCheckTestSupport @@ -54,4 +56,19 @@ public class InterfaceIsTypeCheckTest verify(checkConfig, getPath("InputInterfaceIsType.java"), expected); } + @Test + public void testGetAcceptableTokens() + { + InterfaceIsTypeCheck obj = new InterfaceIsTypeCheck(); + int[] expected = {TokenTypes.INTERFACE_DEF}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } + + @Test + public void testGetRequiredTokens() + { + InterfaceIsTypeCheck obj = new InterfaceIsTypeCheck(); + int[] expected = {TokenTypes.INTERFACE_DEF}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java index 17feb25d3..79109b7e9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java @@ -21,11 +21,13 @@ package com.puppycrawl.tools.checkstyle.checks.design; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; import com.puppycrawl.tools.checkstyle.DefaultConfiguration; +import com.puppycrawl.tools.checkstyle.api.TokenTypes; import org.junit.Test; import java.io.File; import static com.puppycrawl.tools.checkstyle.checks.design.MutableExceptionCheck.MSG_KEY; +import static org.junit.Assert.assertArrayEquals; public class MutableExceptionCheckTest extends BaseCheckTestSupport { @@ -54,4 +56,20 @@ public class MutableExceptionCheckTest extends BaseCheckTestSupport verify(checkConfig, getPath("design" + File.separator + "InputMutableException.java"), expected); } + + @Test + public void testGetAcceptableTokens() + { + MutableExceptionCheck obj = new MutableExceptionCheck(); + int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.VARIABLE_DEF}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } + + @Test + public void testGetRequiredTokens() + { + MutableExceptionCheck obj = new MutableExceptionCheck(); + int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.VARIABLE_DEF}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/ThrowsCountCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/ThrowsCountCheckTest.java index 6943d7873..0b04e4773 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/ThrowsCountCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/ThrowsCountCheckTest.java @@ -22,9 +22,12 @@ package com.puppycrawl.tools.checkstyle.checks.design; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; import com.puppycrawl.tools.checkstyle.DefaultConfiguration; import java.io.File; + +import com.puppycrawl.tools.checkstyle.api.TokenTypes; import org.junit.Test; import static com.puppycrawl.tools.checkstyle.checks.design.ThrowsCountCheck.MSG_KEY; +import static org.junit.Assert.assertArrayEquals; public class ThrowsCountCheckTest extends BaseCheckTestSupport { @@ -54,4 +57,20 @@ public class ThrowsCountCheckTest extends BaseCheckTestSupport verify(checkConfig, getPath("design" + File.separator + "InputThrowsCount.java"), expected); } + + @Test + public void testGetAcceptableTokens() + { + ThrowsCountCheck obj = new ThrowsCountCheck(); + int[] expected = {TokenTypes.LITERAL_THROWS}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } + + @Test + public void testGetRequiredTokens() + { + ThrowsCountCheck obj = new ThrowsCountCheck(); + int[] expected = {TokenTypes.LITERAL_THROWS}; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java index f798ff3eb..63bee33e3 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java @@ -20,7 +20,9 @@ package com.puppycrawl.tools.checkstyle.checks.design; import static com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck.MSG_KEY; +import static org.junit.Assert.assertArrayEquals; +import com.puppycrawl.tools.checkstyle.api.TokenTypes; import org.junit.Test; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; @@ -256,4 +258,16 @@ public class VisibilityModifierCheckTest }; verify(checkConfig, getPath("AnnotatedVisibilitySameTypeName.java"), expected); } + + @Test + public void testGetAcceptableTokens() + { + VisibilityModifierCheck obj = new VisibilityModifierCheck(); + int[] expected = { + TokenTypes.VARIABLE_DEF, + TokenTypes.OBJBLOCK, + TokenTypes.IMPORT, + }; + assertArrayEquals(expected, obj.getAcceptableTokens()); + } }