Issue #2451: removed excess hierarchy from ClassTypeParameterNameCheck

This commit is contained in:
rnveach 2015-11-09 21:45:30 -05:00 committed by Roman Ivanov
parent 4fb4529b6f
commit 4346d41010
2 changed files with 18 additions and 5 deletions

View File

@ -19,6 +19,7 @@
package com.puppycrawl.tools.checkstyle.checks.naming;
import com.puppycrawl.tools.checkstyle.api.DetailAST;
import com.puppycrawl.tools.checkstyle.api.TokenTypes;
/**
@ -47,21 +48,33 @@ import com.puppycrawl.tools.checkstyle.api.TokenTypes;
* @author Travis Schneeberger
*/
public class ClassTypeParameterNameCheck
extends AbstractTypeParameterNameCheck {
extends AbstractNameCheck {
/** Creates a new {@code ClassTypeParameterNameCheck} instance. */
public ClassTypeParameterNameCheck() {
super("^[A-Z]$");
}
@Override
public int[] getRequiredTokens() {
public int[] getDefaultTokens() {
return getAcceptableTokens();
}
@Override
public final int[] getAcceptableTokens() {
return new int[] {
TokenTypes.TYPE_PARAMETER,
};
}
@Override
protected final int getLocation() {
return TokenTypes.CLASS_DEF;
public int[] getRequiredTokens() {
return getAcceptableTokens();
}
@Override
protected final boolean mustCheckName(DetailAST ast) {
final DetailAST location =
ast.getParent().getParent();
return location.getType() == TokenTypes.CLASS_DEF;
}
}

View File

@ -166,7 +166,7 @@ public class ClassTypeParameterNameCheckTest
@Test
public void testGetAcceptableTokens() {
final AbstractTypeParameterNameCheck typeParameterNameCheckObj =
final ClassTypeParameterNameCheck typeParameterNameCheckObj =
new ClassTypeParameterNameCheck();
final int[] actual = typeParameterNameCheckObj.getAcceptableTokens();
final int[] expected = {