From 4a638fc0e6281dcd27ab78bb7e3353dc6a6df086 Mon Sep 17 00:00:00 2001
From: Rick Giles <rickgiles>
Date: Thu, 14 Nov 2002 10:10:27 +0000
Subject: [PATCH] Added global-property to DTD. Removed DTD from XML file until
 fix of ConfigurationLoader

---
 build.xml                  | 3 ++-
 docs/checkstyle_checks.xml | 5 ++++-
 docs/configuration.dtd     | 6 +++++-
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/build.xml b/build.xml
index dad44088b..824205115 100644
--- a/build.xml
+++ b/build.xml
@@ -639,7 +639,8 @@
     <target name="validate.xml"
             depends="require.xerces"
             description="Validates checkstyle XML file">
-        <xmlvalidate file="docs/checkstyle_checks.xml"/>
+        <xmlvalidate file="docs/checkstyle_checks.xml">
+        </xmlvalidate>
     </target>
 
 </project>
diff --git a/docs/checkstyle_checks.xml b/docs/checkstyle_checks.xml
index c5b46e3d4..96ba863f5 100644
--- a/docs/checkstyle_checks.xml
+++ b/docs/checkstyle_checks.xml
@@ -1,8 +1,11 @@
 <?xml version="1.0"?>
+<!-- TODO: fix the loader to not validate the file 
 <!DOCTYPE configuration SYSTEM "configuration.dtd">
-
+ -->
 <configuration>
 
+    <global-property name="tabWidth" value="4"/>
+
     <check classname="com.puppycrawl.tools.checkstyle.checks.AvoidStarImport"/>
 
     <check classname="com.puppycrawl.tools.checkstyle.checks.ConstantNameCheck"/>
diff --git a/docs/configuration.dtd b/docs/configuration.dtd
index d7c2aa565..d6b6e7a5c 100644
--- a/docs/configuration.dtd
+++ b/docs/configuration.dtd
@@ -1,11 +1,15 @@
 <!--
  DTD for a checkstyle configuration.
  -->
-<!ELEMENT configuration (check*)>
+<!ELEMENT configuration (global-property*, check*)>
+<!ELEMENT global-property EMPTY>
 <!ELEMENT check (tokens?, set-property?)>
 <!ELEMENT tokens (#PCDATA)>
 <!ELEMENT set-property EMPTY>
 
+<!ATTLIST global-property name CDATA #REQUIRED
+                          value CDATA #REQUIRED
+>
 <!ATTLIST check classname CDATA #REQUIRED>
 <!ATTLIST set-property name CDATA #REQUIRED
                        value CDATA #REQUIRED