From 4f6d7e415dc3253c5bde537f2a8d262de9b6aba2 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Tue, 18 Aug 2015 22:01:03 +0200 Subject: [PATCH] Use character literals in String.indexOf(). #1555 Fixes `LengthOneStringInIndexOf` inspection violations in test code. Description: >Reports String literals of length one being used as a parameter in String.indexOf() or String.lastIndexOf() calls. These String literals may be replaced by equivalent character literals, gaining some performance enhancement. --- .../google/checkstyle/test/base/BaseCheckTestSupport.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/it/java/com/google/checkstyle/test/base/BaseCheckTestSupport.java b/src/it/java/com/google/checkstyle/test/base/BaseCheckTestSupport.java index d7ef41c17..96a6eba83 100644 --- a/src/it/java/com/google/checkstyle/test/base/BaseCheckTestSupport.java +++ b/src/it/java/com/google/checkstyle/test/base/BaseCheckTestSupport.java @@ -143,8 +143,8 @@ public abstract class BaseCheckTestSupport String actual = lnr.readLine(); assertEquals("error message " + i, expected, actual); String parseInt = removeDeviceFromPathOnWindows(actual); - parseInt = parseInt.substring(parseInt.indexOf(":") + 1); - parseInt = parseInt.substring(0, parseInt.indexOf(":")); + parseInt = parseInt.substring(parseInt.indexOf(':') + 1); + parseInt = parseInt.substring(0, parseInt.indexOf(':')); int lineNumber = Integer.parseInt(parseInt); Integer integer = Arrays.asList(aWarnsExpected).contains(lineNumber) ? lineNumber : 0; assertEquals("error message " + i, (long) integer, lineNumber); @@ -203,7 +203,7 @@ public abstract class BaseCheckTestSupport private static String removeDeviceFromPathOnWindows(String path) { String os = System.getProperty("os.name", "Unix"); if (os.startsWith("Windows")) { - return path.substring(path.indexOf(":") + 1); + return path.substring(path.indexOf(':') + 1); } return path; }