TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

adding test covering #77 change

This commit is contained in:
Ivan Sopov 2013-12-09 02:24:12 +02:00
parent 140bac81ae
commit 503d6babef
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/testinputs/com/puppycrawl/tools/checkstyle/filters/InputSuppressionCommentFilter.java
View File

@ -71,5 +71,13 @@ class InputSuppressionCommentFilter
} catch(Exception ex) {
//CHECKSTYLE:ON
}
try{
//IllegalCatchCheck OFF: Exception
} catch(RuntimeException ex){
} catch(Exception ex){
//IllegalCatchCheck ON: Exception
}
}
}

16
src/tests/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilterTest.java
View File

@ -52,6 +52,8 @@ public class SuppressionCommentFilterTest
"43:17: Name 'T' must match pattern '^[a-z][a-zA-Z0-9]*$'.",
"64:23: Catching 'Exception' is not allowed.",
"71:11: Catching 'Exception' is not allowed.",
"77:11: Catching 'RuntimeException' is not allowed.",
"78:11: Catching 'Exception' is not allowed.",
};
@Test
@ -137,6 +139,20 @@ public class SuppressionCommentFilterTest
verifySuppressed(filterConfig, suppressed);
}
@Test
public void testArgumentSuppression() throws Exception
{
final DefaultConfiguration filterConfig =
createFilterConfig(SuppressionCommentFilter.class);
filterConfig.addAttribute("offCommentFormat", "IllegalCatchCheck OFF\\: (\\w+)");
filterConfig.addAttribute("onCommentFormat", "IllegalCatchCheck ON\\: (\\w+)");
filterConfig.addAttribute("checkFormat", "IllegalCatchCheck");
filterConfig.addAttribute("messageFormat", "^Catching '$1' is not allowed.*$");
final String[] suppressed = {
"78:11: Catching 'Exception' is not allowed.",
};
verifySuppressed(filterConfig, suppressed);
}
@Test
public void testExpansion() throws Exception