Finished port of Local name check - deleted old code
This commit is contained in:
parent
ff49be94c4
commit
50ffeeae38
|
|
@ -58,8 +58,6 @@ public class Configuration
|
|||
PATTERN_DEFAULTS.put(Defn.MEMBER_PATTERN_PROP, "^[a-z][a-zA-Z0-9]*$");
|
||||
PATTERN_DEFAULTS.put(Defn.PUBLIC_MEMBER_PATTERN_PROP,
|
||||
"^f[A-Z][a-zA-Z0-9]*$");
|
||||
PATTERN_DEFAULTS.put(Defn.LOCAL_VAR_PATTERN_PROP,
|
||||
"^[a-z][a-zA-Z0-9]*$");
|
||||
}
|
||||
|
||||
////////////////////////////////////////////////////////////////////////////
|
||||
|
|
@ -349,18 +347,6 @@ public class Configuration
|
|||
return getRegexpProperty(Defn.PUBLIC_MEMBER_PATTERN_PROP);
|
||||
}
|
||||
|
||||
/** @return pattern to match local variables **/
|
||||
String getLocalVarPat()
|
||||
{
|
||||
return getPatternProperty(Defn.LOCAL_VAR_PATTERN_PROP);
|
||||
}
|
||||
|
||||
/** @return regexp to match local variables **/
|
||||
RE getLocalVarRegexp()
|
||||
{
|
||||
return getRegexpProperty(Defn.LOCAL_VAR_PATTERN_PROP);
|
||||
}
|
||||
|
||||
/** @return the maximum constructor length **/
|
||||
int getMaxConstructorLength()
|
||||
{
|
||||
|
|
|
|||
|
|
@ -39,8 +39,6 @@ public interface Defn
|
|||
String MEMBER_PATTERN_PROP = "checkstyle.pattern.member";
|
||||
/** property name for the public member variable pattern **/
|
||||
String PUBLIC_MEMBER_PATTERN_PROP = "checkstyle.pattern.publicmember";
|
||||
/** property name for the method local variable pattern **/
|
||||
String LOCAL_VAR_PATTERN_PROP = "checkstyle.pattern.localvar";
|
||||
/** property name for length of constructors **/
|
||||
String MAX_CONSTRUCTOR_LENGTH_PROP = "checkstyle.maxconstructorlen";
|
||||
/** property name for allowing protected data **/
|
||||
|
|
@ -101,7 +99,6 @@ public interface Defn
|
|||
CONST_PATTERN_PROP,
|
||||
MEMBER_PATTERN_PROP,
|
||||
PUBLIC_MEMBER_PATTERN_PROP,
|
||||
LOCAL_VAR_PATTERN_PROP,
|
||||
};
|
||||
|
||||
/** All the integer properties */
|
||||
|
|
|
|||
|
|
@ -253,13 +253,6 @@ class Verifier
|
|||
void verifyVariable(MyVariable aVar)
|
||||
{
|
||||
if (inMethodBlock()) {
|
||||
if (aVar.getModifierSet().containsFinal()) {
|
||||
}
|
||||
else {
|
||||
checkVariable(aVar,
|
||||
mConfig.getLocalVarRegexp(),
|
||||
mConfig.getLocalVarPat());
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -307,9 +307,6 @@ public class CheckerTest
|
|||
filepath + ":42:40: ',' is not followed by whitespace.",
|
||||
filepath + ":71:30: ',' is not followed by whitespace.",
|
||||
filepath + ":103: Constructor length is 10 lines (max allowed is 9).",
|
||||
filepath + ":119:13: Name 'ABC' must match pattern '^[a-z][a-zA-Z0-9]*$'.",
|
||||
filepath + ":130:18: Name 'I' must match pattern '^[a-z][a-zA-Z0-9]*$'.",
|
||||
filepath + ":132:20: Name 'InnerBlockVariable' must match pattern '^[a-z][a-zA-Z0-9]*$'.",
|
||||
filepath + ":161: Comment matches to-do format 'FIXME:'.",
|
||||
filepath + ":162: Comment matches to-do format 'FIXME:'.",
|
||||
filepath + ":163: Comment matches to-do format 'FIXME:'.",
|
||||
|
|
|
|||
Loading…
Reference in New Issue