From 53e4d78c1934b2681c70d560c8805b1e83199fa5 Mon Sep 17 00:00:00 2001 From: Oliver Burn Date: Fri, 6 Dec 2002 13:40:11 +0000 Subject: [PATCH] Fix some more checkstyle errors. Big thanks Rick for doing the others. --- .../checkstyle/PackageObjectFactory.java | 20 +++++++++---------- .../tools/checkstyle/TreeWalker.java | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java index c6e4c7fda..d71d77bac 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java @@ -12,7 +12,7 @@ public class PackageObjectFactory { /** * Creates a new PackageObjectFactory instance. - */ + */ private PackageObjectFactory() { } @@ -21,13 +21,13 @@ public class PackageObjectFactory * Creates a new instance of a class from a given name. If the name is * a classname, creates an instance of the named class. Otherwise, creates * an instance of a classname obtained by concatenating the given - * to a package name from a given list of package names. + * to a package name from a given list of package names. * @param aPackages list of package names. * @param aLoader the ClassLoader to create the instance with. * @param aName the name of a class. * @return the Object created by aLoader. * @throws CheckstyleException if an error occurs. - */ + */ private Object doMakeObject(String[] aPackages, ClassLoader aLoader, String aName) @@ -38,9 +38,9 @@ public class PackageObjectFactory return createObject(aLoader, aName); } catch (CheckstyleException ex) { - // keep looking + ; // keep looking } - + //now try packages for (int i = 0; i < aPackages.length; i++) { final String className = aPackages[i] + aName; @@ -48,7 +48,7 @@ public class PackageObjectFactory return createObject(aLoader, className); } catch (CheckstyleException ex) { - // keep looking + ; // keep looking } } @@ -81,19 +81,19 @@ public class PackageObjectFactory throw new CheckstyleException( "Unable to instantiate " + aClassName); } - } - + } + /** * Creates a new instance of a class from a given name. If the name is * a classname, creates an instance of the named class. Otherwise, creates * an instance of a classname obtained by concatenating the given - * to a package name from a given list of package names. + * to a package name from a given list of package names. * @param aPackages list of package names. * @param aLoader the ClassLoader to create the instance with. * @param aName the name of a class. * @return the Object created by aLoader. * @throws CheckstyleException if an error occurs. - */ + */ public static Object makeObject(String[] aPackages, ClassLoader aLoader, String aName) throws CheckstyleException diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/TreeWalker.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/TreeWalker.java index 9b447f484..da6f89247 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/TreeWalker.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/TreeWalker.java @@ -248,7 +248,7 @@ public final class TreeWalker while (it.hasNext()) { final String token = (String) it.next(); try { - final int tokenId = TokenTypes.getTokenId(token); + final int tokenId = TokenTypes.getTokenId(token); if (Arrays.binarySearch(acceptableTokens, tokenId) >= 0) { registerCheck(token, aCheck); }