TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor anonymous classes with too many methods. #1555 

Fixes `AnonymousClassMethodCount` inspection violation.

Description:
>Reports anonymous inner class with too many methods. Anonymous classes with more than a very low number of methods may be difficult to understand, and should probably be promoted to become named inner classes.
This commit is contained in:
Michal Kordas 2015-08-08 16:12:11 +02:00 committed by Roman Ivanov
parent 2915ccf21a
commit 57d522e209
1 changed files with 44 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
src/main/java/com/puppycrawl/tools/checkstyle/gui/TreeTableModelAdapter.java
View File

@ -91,45 +91,13 @@ public class TreeTableModelAdapter extends AbstractTableModel {
this.tree = tree;
this.treeTableModel = treeTableModel;
tree.addTreeExpansionListener(new TreeExpansionListener() {
// Don't use fireTableRowsInserted() here; the selection model
// would get updated twice.
@Override
public void treeExpanded(TreeExpansionEvent event) {
fireTableDataChanged();
}
@Override
public void treeCollapsed(TreeExpansionEvent event) {
fireTableDataChanged();
}
});
tree.addTreeExpansionListener(new UpdatingTreeExpansionListener());
// Install a TreeModelListener that can update the table when
// mTree changes. We use delayedFireTableDataChanged as we can
// not be guaranteed the mTree will have finished processing
// the event before us.
treeTableModel.addTreeModelListener(new TreeModelListener() {
@Override
public void treeNodesChanged(TreeModelEvent e) {
delayedFireTableDataChanged();
}
@Override
public void treeNodesInserted(TreeModelEvent e) {
delayedFireTableDataChanged();
}
@Override
public void treeNodesRemoved(TreeModelEvent e) {
delayedFireTableDataChanged();
}
@Override
public void treeStructureChanged(TreeModelEvent e) {
delayedFireTableDataChanged();
}
});
treeTableModel.addTreeModelListener(new UpdatingTreeModelListener());
}
// Wrappers, implementing TableModel interface.
@ -198,4 +166,46 @@ public class TreeTableModelAdapter extends AbstractTableModel {
}
});
}
/**
* TreeExpansionListener that can update the table when tree changes
*/
private class UpdatingTreeExpansionListener implements TreeExpansionListener {
// Don't use fireTableRowsInserted() here; the selection model
// would get updated twice.
@Override
public void treeExpanded(TreeExpansionEvent event) {
fireTableDataChanged();
}
@Override
public void treeCollapsed(TreeExpansionEvent event) {
fireTableDataChanged();
}
}
/**
* TreeModelListener that can update the table when tree changes
*/
private class UpdatingTreeModelListener implements TreeModelListener {
@Override
public void treeNodesChanged(TreeModelEvent e) {
delayedFireTableDataChanged();
}
@Override
public void treeNodesInserted(TreeModelEvent e) {
delayedFireTableDataChanged();
}
@Override
public void treeNodesRemoved(TreeModelEvent e) {
delayedFireTableDataChanged();
}
@Override
public void treeStructureChanged(TreeModelEvent e) {
delayedFireTableDataChanged();
}
}
}