From 5a1b933da2a1dfd2f8c6d107557db23c5ecb87a5 Mon Sep 17 00:00:00 2001
From: Roman Ivanov <ivanov-jr@mail.ru>
Date: Wed, 22 Apr 2015 22:53:18 -0700
Subject: [PATCH] PDM design rules are expanded. Issue #744

---
 config/pmd.xml | 57 +++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 56 insertions(+), 1 deletion(-)

diff --git a/config/pmd.xml b/config/pmd.xml
index 0b7b5c04c..3b23a3af9 100644
--- a/config/pmd.xml
+++ b/config/pmd.xml
@@ -106,7 +106,62 @@
 		</properties>
 	  </rule>
 
-  <!--<rule ref="rulesets/java/design.xml"/>-->
+  <rule ref="rulesets/java/design.xml">
+    <exclude name="UseUtilityClass"/>
+    <exclude name="SimplifyBooleanReturns"/>
+    <exclude name="SimplifyBooleanExpressions"/>
+    <exclude name="SwitchStmtsShouldHaveDefault"/>
+    <exclude name="AvoidDeeplyNestedIfStmts"/>
+    <exclude name="AvoidReassigningParameters"/>
+    <exclude name="SwitchDensity"/>
+    <exclude name="ConstructorCallsOverridableMethod"/>
+    <exclude name="AccessorClassGeneration"/>
+    <exclude name="FinalFieldCouldBeStatic"/>
+    <exclude name="CloseResource"/>
+    <exclude name="NonStaticInitializer"/>
+    <exclude name="DefaultLabelNotLastInSwitchStmt"/>
+    <exclude name="NonCaseLabelInSwitchStatement"/>
+    <exclude name="OptimizableToArrayCall"/>
+    <exclude name="BadComparison"/>
+    <exclude name="EqualsNull"/>
+    <exclude name="ConfusingTernary"/>
+    <exclude name="InstantiationToGetClass"/>
+    <exclude name="IdempotentOperations"/>
+    <exclude name="SimpleDateFormatNeedsLocale"/>
+    <exclude name="ImmutableField"/>
+    <exclude name="UseLocaleWithCaseConversions"/>
+    <exclude name="AvoidProtectedFieldInFinalClass"/>
+    <exclude name="AssignmentToNonFinalStatic"/>
+    <exclude name="MissingStaticMethodInNonInstantiatableClass"/>
+    <exclude name="AvoidSynchronizedAtMethodLevel"/>
+    <exclude name="MissingBreakInSwitch"/>
+    <exclude name="UseNotifyAllInsteadOfNotify"/>
+    <exclude name="AvoidInstanceofChecksInCatchClause"/>
+    <exclude name="AbstractClassWithoutAbstractMethod"/>
+    <exclude name="SimplifyConditional"/>
+    <exclude name="CompareObjectsWithEquals"/>
+    <exclude name="PositionLiteralsFirstInComparisons"/>
+    <exclude name="PositionLiteralsFirstInCaseInsensitiveComparisons"/>
+    <exclude name="UnnecessaryLocalBeforeReturn"/>
+    <exclude name="NonThreadSafeSingleton"/>
+    <exclude name="UncommentedEmptyMethod"/>
+    <exclude name="UncommentedEmptyConstructor"/>
+    <exclude name="AvoidConstantsInterface"/>
+    <exclude name="UnsynchronizedStaticDateFormatter"/>
+    <exclude name="PreserveStackTrace"/>
+    <exclude name="UseCollectionIsEmpty"/>
+    <exclude name="ClassWithOnlyPrivateConstructorsShouldBeFinal"/>
+    <exclude name="EmptyMethodInAbstractClassShouldBeAbstract"/>
+    <exclude name="SingularField"/>
+    <exclude name="ReturnEmptyArrayRatherThanNull"/>
+    <exclude name="AbstractClassWithoutAnyMethod"/>
+    <exclude name="TooFewBranchesForASwitchStatement"/>
+    <exclude name="LogicInversion"/>
+    <exclude name="UseVarargs"/>
+    <exclude name="FieldDeclarationsShouldBeAtStartOfClass"/>
+    <exclude name="GodClass"/>
+    <exclude name="AvoidProtectedMethodInFinalClassNotExtending"/>
+  </rule>
   <rule ref="rulesets/java/empty.xml"/>
   <rule ref="rulesets/java/finalizers.xml"/>
   <rule ref="rulesets/java/imports.xml"/>