From 5c5eafaa7e6367e84de45df655c210c82f74eaa8 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Mon, 31 Aug 2015 23:26:48 +0200 Subject: [PATCH] Issue #1555: Replace constructor with setUp() in JUnit test case Fixes `TestCaseWithConstructor` inspection violations. Description: >Reports on JUnit test cases with initialization logic in their constructors. Initialization of JUnit test cases should be done in setUp() methods instead. --- .../checkstyle/checks/naming/TypeNameCheckTest.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeNameCheckTest.java index c7fd4a891..e3790d357 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeNameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeNameCheckTest.java @@ -26,6 +26,7 @@ import java.io.File; import java.io.IOException; import org.apache.commons.lang3.ArrayUtils; +import org.junit.Before; import org.junit.Test; import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport; @@ -36,11 +37,11 @@ import com.puppycrawl.tools.checkstyle.utils.TokenUtils; public class TypeNameCheckTest extends BaseCheckTestSupport { - private final String inputFilename; + private String inputFilename; - public TypeNameCheckTest() throws IOException { - inputFilename = getPath("naming" + File.separator - + "InputTypeName.java"); + @Before + public void setUp() throws IOException { + inputFilename = getPath("naming" + File.separator + "InputTypeName.java"); } @Test